Add AssemblyResolve handler for in-memory assemblies in CodeTaskFactory #1486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We know that since the assembly is loaded via
Assembly.Load(byte[]), it is not allowed to use loaded dependencies because they came from a different load context. This change keeps a static dictionary around with a mapping of assembly strong name and assembly. If the inline task asks for the dependency at run time, the assembly resolve handler will return the loaded assembly if the strong name is the same.Users will still experience runtime exceptions if they only list top-level dependencies in their
<Reference />list. To get around this, they'll need to list the full closure of dependencies that are not in the GAC or the MSBuild.exe directory.Closes #594