Check schema when performing a sln build. #2593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdmihai
approved these changes
Oct 16, 2017
|
@AndyGerlicher should this fix still go in now that this type of project is supported? |
rainersigwald
approved these changes
Dec 14, 2017
* Check that the schema matches either empty or the MSBuild default schema when building a solution file. * Special case .rptproj files. This file format looks like a standard MSBuild file but specifies ToolsVersion=2.0 and a default XML schema. Since the XML parser treats that schema as equivalent to empty and empty is now allowed, there's no good way to determine if it's an MSBuild file until we try to parse. This results in an error in MSBuild 15 rather than a warning in MSBuild 14 for solutions with a .rptproj file. To solve this, the sln build will now allow projects where the schema is the default MSBuild schema or empty and ToolsVersion is not 2.0. Partial fix for dotnet#2064
AndyGerlicher
force-pushed
the
nonmsbuildnamespace
branch
from
dcc24d6 to
3300c06
Compare
AndyGerlicher
force-pushed
the
nonmsbuildnamespace
branch
from
3300c06 to
4fd6871
Compare
rainersigwald
approved these changes
Jan 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note this doesn't fix the
.dwprojcase. I need to figure out something slightly different for that, but I wanted to send this out because I need to move on for now.Check that the schema matches either empty or the MSBuild default schema
when building a solution file.
Special case .rptproj files. This file format looks like a standard
MSBuild file but specifies ToolsVersion=2.0 and a default XML schema.
Since the XML parser treats that schema as equivalent to empty and empty
is now allowed, there's no good way to determine if it's an MSBuild file
until we try to parse. This results in an error in MSBuild 15 rather
than a warning in MSBuild 14 for solutions with a .rptproj file. To
solve this, the sln build will now allow projects where the schema is
the default MSBuild schema or empty and ToolsVersion is not 2.0.
Partial fix for #2064