Bump up msbuild to newer corefx versions #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet-bot test OSX Build please |
| [Trait("Category", "netcore-osx-failing")] | ||
| [Trait("Category", "mono-osx-failing")] | ||
| public void InvalidPathAndMetadataItemFunction() | ||
| [PlatformSpecific(PlatformID.Windows)] |
|
|
cdmihai
force-pushed
the
nugetFixes
branch
2 times, most recently
from
fd087c1 to
5a88aca
Compare
|
@dotnet-bot test this please |
For some weird reason beyond my Nuget comprehension it works now.
update whitelist test
…til the method name is known
Types for the receiver of static property function calls resolved from
the type cache in AvailableStaticMethods only when they were types with
all of their methods whitelisted (thus appearing only with their type
name in the cache, not typeName::methodName). This caused partially
whitelisted types as File and Directory to always miss the cache and
resolve with Type.GetType()
On .net core this is a problem because namespaces are being moved out
from mscorlib to their own dlls, which causes Type.GetType to fail
because it assumes that namespace qualified types are from either the
current assembly, or from mscorlib. For example,
Type.GetType("System.IO.File") resolves on net46 but not on .net core.
To fix this, I delayed the type resolution for static invocations only
after the method name is known. This way, the code can construct the
method qualified name and properly search the cache for the type.
Other edits:
- refactored Function.ExtractPropertyFunction to use disjunct
construction branches for each type of property function, rather than a
soup of intertwined logic. Should make future refactoring easier (i.e.,
creating some builder subclasses for each property function type)
- added a FunctionBuilder type that aggregates all the function parts
needed for a property function and changed the code to use it. This way,
control flow gets decoupled from a partially constructed function which
allows me to easily change the order in which functions parts get
constructed. Downside is the function state duplication.
- added convenience methods in the AvailableStaticMethods class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Func<Type, object, bool>