Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve vs debugging #6398

Merged
merged 3 commits into from
May 28, 2021
Merged

Improve vs debugging #6398

merged 3 commits into from
May 28, 2021

Conversation

cdmihai
Copy link
Contributor

@cdmihai cdmihai commented May 1, 2021

Changes Made

  • updated VS deploy script to copy more files needed during runtime
  • added option to break into the BuildManager via a new env var. This makes it super easy to debug msbuild running in devenv without having to copy over local bits

Copy link
Member

@Forgind Forgind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two parts seem pretty distantly related, but I'm fine with that.

@cdmihai
Copy link
Contributor Author

cdmihai commented May 3, 2021

@Forgind, I added a new option to filter the process to break into. VS instantiates BuildManager instances in devenv.exe and also launches msbuild.exes. It all becomes a bit chaotic without a way to specify that you want to only break into devenv.exe's build managers.

@Forgind Forgind added the merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now. label May 9, 2021
@Forgind Forgind merged commit ec23638 into dotnet:main May 28, 2021
cdmihai added a commit to cdmihai/msbuild that referenced this pull request Jun 16, 2021
Changes Made
updated VS deploy script to copy more files needed during runtime
added option to break into the BuildManager via a new env var. This makes it super easy to debug msbuild running in devenv without having to copy over local bits
@cdmihai cdmihai deleted the improveVSDebugging branch June 26, 2021 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants