Add solution-validation targets as hook points #6454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution metaprojects are assembled in a confusing way that impacts what targets can be hooked into via BeforeTargets/AfterTargets. Prior to this change one couldn't hook before the build would attempt to traverse the list of projects in the solution. Extend the "list of targets we know we'll create shortly" list to include the things that are in the `InitialTargets` list and `GetSolutionConfigurationContents`. Fixes dotnet#6452.
bruno-garcia
approved these changes
May 13, 2021
Forgind
approved these changes
May 14, 2021
benvillalobos
approved these changes
May 17, 2021
rainersigwald
added
the
merge-when-branch-open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution metaprojects are assembled in a confusing way that impacts what
targets can be hooked into via BeforeTargets/AfterTargets. Prior to this
change one couldn't hook before the build would attempt to traverse the
list of projects in the solution.
Extend the "list of targets we know we'll create shortly" list to
include the things that are in the
InitialTargetslist andGetSolutionConfigurationContents.Fixes #6452.
Context
See related #4694, #5109.