Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Update dependencies from dotnet/arcade #6478

Merged
merged 9 commits into from
Jun 1, 2021

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented May 24, 2021

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: 93d865d2-823f-4e4d-e0b6-08d91b0a84f2
  • Build: 20210531.1
  • Date Produced: 5/31/2021 7:30 PM
  • Commit: c7d6bd607715f334cda90e01967bb0c02dee09be
  • Branch: refs/heads/main

…524.3

Microsoft.DotNet.Arcade.Sdk
 From Version 6.0.0-beta.21227.1 -> To Version 6.0.0-beta.21274.3
@Forgind
Copy link
Member

Forgind commented May 24, 2021

@benvillalobos this looks like a normal version update, but it failed everywhere. Since you've been working with arcade recently, would you mind taking a look?

@benvillalobos
Copy link
Member

Looks like it's looking for dependencies from a different arcade version:

##[error].dotnet\sdk\6.0.100-preview.3.21202.5\Microsoft.Common.CurrentVersion.targets(4965,5): error MSB3030: (NETCORE_ENGINEERING_TELEMETRY=Build) Could not copy the file "D:\a\1\s\.dotnet\sdk\6.0.100-preview.2.21155.3\Microsoft.NETCoreSdk.BundledVersions.props" because it was not found.
is looking for 6.0.100-preview.2.21155.3, but the error comes from D:\a\1\s\.dotnet\sdk\6.0.100-preview.3.21202.5\Microsoft.Common.CurrentVersion.targets(4965,5) (notice the version numbers).

I think I know what's up. Update Versions.props to match DotNetCliVersion with the version in this PR's global.json

…524.6

Microsoft.DotNet.Arcade.Sdk
 From Version 6.0.0-beta.21227.1 -> To Version 6.0.0-beta.21274.6
@jonfortescue
Copy link
Contributor

Commenting to be notified when this is merged.

dotnet-maestro bot added 5 commits May 26, 2021 12:26
…525.5

Microsoft.DotNet.Arcade.Sdk
 From Version 6.0.0-beta.21227.1 -> To Version 6.0.0-beta.21275.5
…526.5

Microsoft.DotNet.Arcade.Sdk
 From Version 6.0.0-beta.21227.1 -> To Version 6.0.0-beta.21276.5
…527.1

Microsoft.DotNet.Arcade.Sdk
 From Version 6.0.0-beta.21227.1 -> To Version 6.0.0-beta.21277.1
…528.1

Microsoft.DotNet.Arcade.Sdk
 From Version 6.0.0-beta.21227.1 -> To Version 6.0.0-beta.21278.1
…531.1

Microsoft.DotNet.Arcade.Sdk
 From Version 6.0.0-beta.21227.1 -> To Version 6.0.0-beta.21281.1
@rainersigwald
Copy link
Member

The ref assembly source change is legit and should be committed now I think. It should be stabilized by #6431 and thus only change again if the compiler does (again).

@Forgind Forgind merged commit b18e3ff into main Jun 1, 2021
@Forgind Forgind deleted the darc-main-cb9b9c3b-4a8d-4a6d-bd21-9f32e1af7685 branch June 1, 2021 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants