Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move RichCodeNav to its own job #6505

Merged
merged 1 commit into from
Jun 2, 2021
Merged

Move RichCodeNav to its own job #6505

merged 1 commit into from
Jun 2, 2021

Conversation

rainersigwald
Copy link
Member

It's taking longer than we initially hoped so moving it to get it off the critical path.

@rainersigwald
Move RichCodeNav to its own job
cddcc3b 
It's taking longer than we initially hoped so moving it to get it off the critical path.
Forgind
Forgind approved these changes Jun 1, 2021
View reviewed changes
Copy link
Member

@Forgind Forgind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if we should let CI pass even if this fails, but eh

@rainersigwald
Copy link
Member Author

continueOnError: true should do that (it'll be SucceededWithIssues instead of Succeeded but should show as passed).

@rainersigwald rainersigwald added the merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now. label Jun 1, 2021
@rainersigwald
Copy link
Member Author

Ah; that's not on the build.cmd invocation but . . . that should always work too; I don't mind "testing" it in this job.

@Forgind Forgind merged commit 813f854 into dotnet:main Jun 2, 2021
@rainersigwald rainersigwald deleted the move-richcodenav branch June 2, 2021 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Forgind Forgind Forgind approved these changes

Assignees
No one assigned
Labels
merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rainersigwald @Forgind