Upgrade System.Net.Http package version #6879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…age to overpower undirect references to a lower version.
… reference instead.
|
Talked to @rainersigwald, we need to fix our sample .csproj files too. I will update this PR. |
rokonec
approved these changes
Sep 23, 2021
rainersigwald
approved these changes
Sep 23, 2021
|
|
||
| <ProjectReference Include="..\Build\Microsoft.Build.csproj" /> | ||
| <ProjectReference Include="..\Framework\Microsoft.Build.Framework.csproj" /> | ||
| <ProjectReference Include="..\MSBuild\MSBuild.csproj" /> | ||
| <ProjectReference Include="..\Tasks\Microsoft.Build.Tasks.csproj" /> | ||
| <ProjectReference Include="..\Utilities\Microsoft.Build.Utilities.csproj" /> | ||
| <ProjectReference Include="..\Xunit.NetCore.Extensions\Xunit.NetCore.Extensions.csproj" /> | ||
| <ProjectReference Include="..\Samples\PortableTask\PortableTask.csproj" ReferenceOutputAssembly="false" Private="false" SetTargetFramework="TargetFramework=netstandard1.3" /> | ||
| <ProjectReference Include="..\Samples\PortableTask\PortableTask.csproj" ReferenceOutputAssembly="false" Private="false" SetTargetFramework="TargetFramework=netstandard2.0" /> |
There was a problem hiding this comment.
Feels like this SetTargetFramework shouldn't be needed any more, but that can wait for another time.
Forgind
pushed a commit
that referenced
this pull request
Feb 15, 2022
Changes Made Changes package reference to the System.Net.Http to an assembly reference for .NETFramework. Notes Reverts part of #6879.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Upgrading version of System.Net.Http package to the latest one, that is 4.3.4.
Changes Made
We have indirect references to System.Net.Http with lesser versions (that is, v4.3.0 is a dependency of our nuget dependencies).
I added a direct reference to our .csproj files in order to overwrite the version we take.
Also, in couple of projects we have an assembly reference to the System.Net.Http, which I replaced by a package reference.
Testing
Unit tests & DDRITs.