Enable File Scoped Namespaces For Resources #6881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of the way the csharparser was written, we can easily modify the state machine to stop looking for a namespace when we see a semicolon
rainersigwald
approved these changes
Sep 22, 2021
Forgind
added
the
merge-when-branch-open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6828
Context
CreateCSharpManifestResourceName uses a c# file parser to extract the namespace and classname to create its resource name. See the original issue for a clear explanation on how this breaks with file-scoped namespaces.
Changes Made
Modify the state machine within the csharp parser to stop looking for a namespace when we encounter a semicolon.
Testing
Notes
Review the final diff