Avoid appending x64 to AL path if x64 is already appended

[benvillalobos]

Fixes users who previously worked around the issue of msbuild not using the x64 version of AL.exe.

Context

Changes Made

Only append x64\ to _AlExeToolPath when PlatformTarget == x64 AND _AlExeToolPath doesn't already end with x64\

Testing

Tested locally

Notes

[jhennessey]

There is a missing ). So, .EndsWith('x64\') -> .EndsWith('x64\'))

Good news is, this change gets rid of a ton of MSB3084 warnings I was getting. Here's the warning I was getting in case others report it:

Task attempted to find "al.exe" in two locations. 1) Under the "C:\Program Files (x86)\Microsoft SDKs\Windows\v10.0A\bin\NETFX 4.8 Tools\x64\x64" processor specific directory which is generated based on SdkToolsPath 2) The x86 specific directory under "C:\Program Files (x86)\Microsoft SDKs\Windows\v10.0A\bin\NETFX 4.8 Tools\x64\x64" which is specified by the SDKToolsPath property. You may be able to solve the problem by doing one of the following: 1) Set the "SDKToolsPath" property to the location of the Microsoft Windows SDK.

[benvillalobos]

ah good catch!

Do you happen to know where it had x64\ appended prior to this target running? The original issue suggested it was never getting appended, but it sounds like other packages were manually appending it and now this is conflicting.

[jhennessey]

Do you happen to know where it had x64\ appended prior to this target running? The original issue suggested it was never getting appended, but it sounds like other packages were manually appending it and now this is conflicting.

Oh, geez...It looks like someone implemented a suggestion from stackoverflow in our codebase to alleviate AL1073 warnings. So your fix in #6484 means that can be removed. Kindly disregard 😊.