Accept TaskOutput when filtering events for EmbedInBinlog
#7869
Conversation
| <WriteLinesToFile File=""./testtaskoutputfile.txt"" Lines=""abc;def;ghi""/> | ||
| <CreateItem Include=""./testtaskoutputfile.txt""> |
There was a problem hiding this comment.
I imagine these slashes don't work on windows?
There was a problem hiding this comment.
I think the convention is to use the \ on all OSs (and MSBuild will convert correctly where needed).
There was a problem hiding this comment.
Will look at this later today - don't want to use build infrastructure to potentially back and forth on test success.
| ObjectModelHelpers.BuildProjectExpectSuccess(testProject, binaryLogger); | ||
| var projectImportsZipPath = Path.ChangeExtension(_logFile, ".ProjectImports.zip"); | ||
| using var fileStream = new FileStream(projectImportsZipPath, FileMode.Open); | ||
| using var zipArchive = new ZipArchive(fileStream, ZipArchiveMode.Read); |
There was a problem hiding this comment.
Consider using TestEnvironment and TransientZipArchive?
There was a problem hiding this comment.
TransientZipArchive is only for creating a zip archive not the other way around and i don't think TestEnvironment would help here really - ObjectModelHelpers.BuildProjectExpectSuccess already uses it internally, the _logFile path is attached to it implicitly - pretty much the only path i produce is the .ProjectImports.zip, which is just conventionally attached to the binlog path.
|
I can just drop the explicit path - that fixes building on both windows and linux. |
…r EmbedInBinlog Before we only interpreted plain AddItem messages as directives for file embedding. Resolves #7665
|
I looked at documentation for ZipArchive. It explicitly states that it looks after the last path separator character (\). I'm guessing it hasn't been made unix-friendly and doesn't realize that there are other slashes 😄 |
|
Oh my lord - 😂😂 - well imma have to work around that now 🥳🥳 i guess @KirillOsenkov i assume this doesn't show up on your end because you are working with the fully qualified path anyways? |
… on Unix filesystems
…rmance Co-authored-by: Forgind <Forgind@users.noreply.github.com>
Forgind
added
the
merge-when-branch-open
benvillalobos
changed the title
TaskParameterMessageKind.TaskOutput when filtering events for EmbedInBinlogTaskOutput when filtering events for EmbedInBinlog
|
Thanks for the contribution! |
Before we only interpreted plain AddItem messages as directives for file embedding.
Resolves #7665
Changes Made
Added TaskParameterEvents with kind
TaskOutputto the event filter for embedding files.Testing
I started out writing tests to catch a dedicated FileImported, because i thought the file was embedded as a payload inside a BuildEvent somehow, but if i get this correctly the archive is just a secondary payload to the binlog - meant for readers to use as a dictionary to look for files without any guarantees that files are actually there.
I'm not actually digging inside the .binlog file, but i found reading the external *.ProjectImports.zip to be an acceptable alternative to get at least some coverage regarding EmbedInBinlog resulting in embedded files.