-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump up dotnet version to fix CG alerts #9096
Conversation
Hello! I noticed that you're targeting one of our servicing branches. Please consider updating the version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@@ -3,7 +3,7 @@ | |||
"allowPrerelease": true | |||
}, | |||
"tools": { | |||
"dotnet": "7.0.304", | |||
"dotnet": "7.0.306", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Puting a comment here to block possible auto-merge.
All is good - I just do not know if we can merge to 17.7 without any tag/tell/approval process (it's just an infra stuff, so probably not a problem - but just for sure).
Taging @rainersigwald - is this considered servicing? Or can we generaly just go ahead with infra-only changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Required infra for servicing is generally ok, the approval for the subsequent servicing bug includes "and the changes you are required to make to get it to build and ship" unless they're huge--and bumping to a new released SDK is not a problem. I think this is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do really need to bump the version though.
@@ -3,7 +3,7 @@ | |||
"allowPrerelease": true | |||
}, | |||
"tools": { | |||
"dotnet": "7.0.304", | |||
"dotnet": "7.0.306", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Required infra for servicing is generally ok, the approval for the subsequent servicing bug includes "and the changes you are required to make to get it to build and ship" unless they're huge--and bumping to a new released SDK is not a problem. I think this is fine.
Fixes #
N/A
Context
CG alerts for vs17.7 recommends the following upgrade from 7.0.7 to 7.0.9.
Changes Made
Bump up dotnet version to 7.0.306 that has runtime 7.0.9.
Testing
Notes