Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump up dotnet version to fix CG alerts #9096

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

GangWang01
Copy link
Member

Fixes #
N/A

Context

CG alerts for vs17.7 recommends the following upgrade from 7.0.7 to 7.0.9.

  • Microsoft.AspNetCore.App.Runtime.win-x64
  • Microsoft.AspNetCore.App.Runtime.win-x86
  • Microsoft.WindowsDesktop.App.Runtime.win-x64
  • Microsoft.WindowsDesktop.App.Runtime.win-x86

Changes Made

Bump up dotnet version to 7.0.306 that has runtime 7.0.9.

Testing

Notes

@ghost
Copy link

ghost commented Aug 2, 2023

Hello! I noticed that you're targeting one of our servicing branches. Please consider updating the version.

Copy link
Member

@JanKrivanek JanKrivanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@@ -3,7 +3,7 @@
"allowPrerelease": true
},
"tools": {
"dotnet": "7.0.304",
"dotnet": "7.0.306",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puting a comment here to block possible auto-merge.
All is good - I just do not know if we can merge to 17.7 without any tag/tell/approval process (it's just an infra stuff, so probably not a problem - but just for sure).
Taging @rainersigwald - is this considered servicing? Or can we generaly just go ahead with infra-only changes?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required infra for servicing is generally ok, the approval for the subsequent servicing bug includes "and the changes you are required to make to get it to build and ship" unless they're huge--and bumping to a new released SDK is not a problem. I think this is fine.

Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do really need to bump the version though.

@@ -3,7 +3,7 @@
"allowPrerelease": true
},
"tools": {
"dotnet": "7.0.304",
"dotnet": "7.0.306",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required infra for servicing is generally ok, the approval for the subsequent servicing bug includes "and the changes you are required to make to get it to build and ship" unless they're huge--and bumping to a new released SDK is not a problem. I think this is fine.

@JanKrivanek JanKrivanek merged commit 8ec440e into dotnet:vs17.7 Aug 2, 2023
8 checks passed
@GangWang01 GangWang01 deleted the fix-cg-alerts branch August 3, 2023 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants