Provide cross-platform environment statistics collection + Modify OverloadDetector to account for memory too
#8820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ledjon-behluli
commented
Jan 16, 2024
•
ledjon-behluli
commented
- Provides cross-platform environment statistics collection
- fixes Add memory capacity to overload detector #8819
ReubenBond
reviewed
Jan 17, 2024
ReubenBond
reviewed
Jan 17, 2024
ReubenBond
reviewed
Jan 17, 2024
ReubenBond
reviewed
Jan 17, 2024
ledjon-behluli
force-pushed
the
windows-environment-statistics
branch
2 times, most recently
from
998ceb5
to
2bcedf4
Compare
ledjon-behluli
force-pushed
the
windows-environment-statistics
branch
from
c39c03e
to
3c1c72e
Compare
added 10 commits
January 19, 2024 13:29
…nymore + removed need for validation of IHostEnvironmentStatistics in LoadSheddingValidator & test govering it
…not account for it.
ledjon-behluli
changed the title
OverloadDetector to account for memory too
ledjon-behluli
commented
Jan 22, 2024
src/Orleans.Runtime/Placement/ResourceOptimizedPlacementDirector.cs
Outdated
Show resolved
Hide resolved
added 5 commits
January 22, 2024 20:38
…all at once as opposed to each time calling a property, and adjust all call sites
…+ changed logic to pass struct to OverloadDetectionLogic to avoid multiple calls to GC.GetMemoryInfo()
ReubenBond
force-pushed
the
windows-environment-statistics
branch
2 times, most recently
from
ba8841c
to
3f5c7fd
Compare
ReubenBond
force-pushed
the
windows-environment-statistics
branch
from
3f5c7fd
to
1f14d1b
Compare
…call sites + some comements and stuff
ReubenBond
approved these changes
Jan 23, 2024
ReubenBond
reviewed
Jan 23, 2024
src/Orleans.Core.Abstractions/Statistics/IAppEnvironmentStatistics.cs
Outdated
Show resolved
Hide resolved
ReubenBond
reviewed
Jan 23, 2024
src/Orleans.Core.Abstractions/Statistics/IAppEnvironmentStatistics.cs
Outdated
Show resolved
Hide resolved
ReubenBond
approved these changes
Jan 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.