Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8952
This PR implements the above proposal to align
IGrainTimer
more closely withTimer
from the BCL, granting users a couple of useful additions:dueTime
andperiod
can be changed after the timer has been created.Here are the key API changes:
This PR implements the following:
IGrainTimer
publicIGrainTimer
to match theChange(dueTime, period)
style ofITimer
from the BCLRegisterTimer
methods to returnIGrainTimer
instead of justIDisposable
GrainTimer
, which is the class which implementsIGrainTimer
to support this functionality, and update consumers to accommodate.Microsoft Reviewers: Open in CodeFlow