Adding codec to serialize F# Unit #9039
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
Unit
in Grain interfaces defined in F#, the Silo startup fails with the messageOrleans.Serialization.CodecNotFoundException Could not find a codec for type Microsoft.FSharp.Core.Unit.
We have previously gotten around this by creating a Surrogate like this in C#This PR tries to add support for serializing
Unit
directly by creating aUnit
codec. The implementation is based on the implementation of thenull
-case inNullableCodec<T>
. I'm note sure theCopier
implementation is actually required, as the unit-test succeeds without it.To test the
FSharpUnitCodec
I have created a F#-testproject, since I can't useUnit
from C#. I have also moved the roundtrip serialization tests for Discriminated Unions to this project. Let me know if this is not desirable.Microsoft Reviewers: Open in CodeFlow