New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port and improve Perf_Marvin #44

Closed

3 tasks done

adamsitnik opened this issue Jun 26, 2018 · 0 comments

Member

adamsitnik commented Jun 26, 2018 •

edited

Loading

Port from xunit-performance to BenchmarkDotNet
investigate why the benchmarks are not calling Marvin API from CoreFX, but instead, have it's own copy of the hashing algorithm. IMHO it creates a need to synchronize the code between repositories and makes it possible to miss a regression if somebody changes the implementation in CoreFX
reduce the number of permutations, it's more a unit test than a benchmark today.

ViktorHofer self-assigned this

adamsitnik unassigned ViktorHofer

adamsitnik mentioned this issue

Merged

adamsitnik closed this as completed in #114

ViktorHofer mentioned this issue

Port xunit benchmark tests to BenchmarkDotNet dotnet/runtime#26648

Closed

31 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment