Marvin #114
Merged
Marvin #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorive
reviewed
Aug 14, 2018
| public void Setup() => _string = new string(Enumerable.Repeat('a', BytesCount / (sizeof(char)/ sizeof(byte))).ToArray()); | ||
|
|
||
| [Benchmark] | ||
| public int ComputeHash() => _string.GetHashCode(); |
There was a problem hiding this comment.
The name of the benchmark here would be System.Hashing.ComputeHash. Would it make more sense to be called GetHashCode instead? Or something more descriptive?
There was a problem hiding this comment.
The problem is that GetHashCode method exists in the base class (object) so we would need to override the GetHashCode method and the benchmark would include the virtual method invocation cost.
I was also trying to find better class name, but:
- I can't call it Marvin because such type exists, and for .NET and .NET Core 2.0- the implementation was not Marvin algo.
- The
HashCodename is taken by existing type
I am open to better ideas, I just run out of name ideas ;)
There was a problem hiding this comment.
Maybe something like System.Hashing.GetDefaultStringHashCode ?
There was a problem hiding this comment.
Maybe GetStringHashCode ?
jorive
approved these changes
Aug 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44
The original CoreFX benchmarks have it's own copy of Marvin and benchmark the copy. Which needs to be kept in sync manually. I think that we should avoid that.
As @ViktorHofer explained this was because the Marvin class is internal and to make it public we would need to go through API review.
IMHO the best we can do right now is to benchmark
string.GetHashCodewhich is just a call toMarvin.ComputeHash.It also allows us to compare
string.GetHashCodefor .NET and .NET Core, where due to security reasons we have regressed the performance https://github.com/dotnet/corefx/issues/30994@jorive @ViktorHofer what do you think?
dotnet run -c Release -f netcoreapp2.1 -- -f *Hashing* --clr --core21 --join