System.Runtime #112
System.Runtime #112
Conversation
…tly (double.NaN etc)
…arks in the same type
…le. From 1472 to 1248 benchmarks
…umentsSource to show devs how MANY test cases we have, -21 benchmarks
|
@jorive I added a simple validator to prevent the people from adding too many test cases with I did that after I found few benchmarks with HOUNRDRES of test cases... |
…NUS TWO HUNDRED TWELVE BENCHMARKS
…S ONE HUNDRED EIGHTY EIGHT BENCHMARKS
…ases it's much cleaner now
| @@ -0,0 +1,29 @@ | |||
| using System.Collections.Generic; | |||
|
Ready for review, I have ported the benchmarks and removed a LOT of test cases that very often were providing no value. Before we had 1500 benchmarks in "System.Tests" namespace, now 212. |
| => string.Format(s, o); | ||
|
|
||
| [Benchmark] | ||
| public string Format_MultipleArgs() |
There was a problem hiding this comment.
Do we need a similar case for string interpolation? For example:
$"{arg1} {arg2}"
``` #ClosedThere was a problem hiding this comment.
good idea! I added the test case for string interpolation
|
|
||
| [Benchmark] | ||
| [Arguments("This is a very nice sentence", 'z', 'y')] // 'z' does not exist in the string | ||
| [Arguments("This is a very nice sentence", 'i', 'I')] // 'i' occuress 3 times in the string |
There was a problem hiding this comment.
nit: "This is a very nice benchmark sentence" ;) … hehe #Closed
There was a problem hiding this comment.
do not need to change it! #Closed
Fixes #68
@ViktorHofer after I am done with this task I will be taking other tasks that are not finished, even if they are assigned to someone else ;p
For the first time of CoreFX port I have hit a bug in BDN: dotnet/BenchmarkDotNet#851 and dotnet/BenchmarkDotNet#850