-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EventListener microbenchmarks #1800
Conversation
@MihaZupan do you plan to complete this PR? do you need a review? I will rerun validation. |
Should just need a review |
src/benchmarks/micro/libraries/System.Diagnostics.Tracing/Perf_EventListener.cs
Outdated
Show resolved
Hide resolved
src/benchmarks/micro/libraries/System.Diagnostics.Tracing/Perf_EventListener.cs
Outdated
Show resolved
Hide resolved
Why not bring the whole test which testing with the http operations? |
The changes here look ok to me. I'll let @noahfalk have a look too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The whole benchmark was there to estimate the benefit for real-world use cases. The benchmarks included with this PR should represent the underlying operations well and catch any regressions. |
Thanks @MihaZupan . Always good to see benchmark holes plugged. |
The networking telemetry we added to runtime in 5.0 uses
EventSource
and users can useEventListener
to observe these events in the same process.This PR brings a subset of Benchmarks.cs (used in dotnet/runtime#51822, dotnet/runtime#52092, dotnet/runtime#52455) to this repo to get some coverage of
EventListener
.cc: @noahfalk