Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EventListener microbenchmarks #1800

Merged
merged 3 commits into from
Feb 8, 2022
Merged

Conversation

MihaZupan
Copy link
Member

The networking telemetry we added to runtime in 5.0 uses EventSource and users can use EventListener to observe these events in the same process.

This PR brings a subset of Benchmarks.cs (used in dotnet/runtime#51822, dotnet/runtime#52092, dotnet/runtime#52455) to this repo to get some coverage of EventListener.

cc: @noahfalk

@danmoseley
Copy link
Member

@MihaZupan do you plan to complete this PR? do you need a review?

I will rerun validation.

@danmoseley danmoseley closed this Feb 5, 2022
@danmoseley danmoseley reopened this Feb 5, 2022
@MihaZupan
Copy link
Member Author

Should just need a review

@danmoseley
Copy link
Member

@safern or @tarekgh perhaps one of you could review? I do not have enough familiarity with this API.

@tarekgh
Copy link
Member

tarekgh commented Feb 6, 2022

This PR brings a subset of Benchmarks.cs (used in dotnet/runtime#51822, dotnet/runtime#52092, dotnet/runtime#52455) to this repo to get some coverage of EventListener.

Why not bring the whole test which testing with the http operations?

@tarekgh
Copy link
Member

tarekgh commented Feb 6, 2022

The changes here look ok to me. I'll let @noahfalk have a look too.

Copy link
Member

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MihaZupan
Copy link
Member Author

This PR brings a subset of Benchmarks.cs (used in dotnet/runtime#51822, dotnet/runtime#52092, dotnet/runtime#52455) to this repo to get some coverage of EventListener.

Why not bring the whole test which testing with the http operations?

The whole benchmark was there to estimate the benefit for real-world use cases. The benchmarks included with this PR should represent the underlying operations well and catch any regressions.

@danmoseley danmoseley merged commit 5dbf9be into dotnet:main Feb 8, 2022
@danmoseley
Copy link
Member

Thanks @MihaZupan . Always good to see benchmark holes plugged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants