CoreFX workflow docs #314
CoreFX workflow docs #314
Conversation
| C:\Projects\corefx\src\System.Text.RegularExpressions\src> dotnet msbuild /p:ConfigurationGroup=Release | ||
| ``` | ||
|
|
||
| ## Preventing Regressions |
There was a problem hiding this comment.
@danmosemsft this is something new, I would like it to become a part of our perf culture (thinking of perf up-front and using tools to validate that)
|
|
||
| **It's very important to validate the reported version numbers** to make sure that you are running the benchmarks using the versions you think that you are using. | ||
|
|
||
| ## Benchmarking new API |
There was a problem hiding this comment.
@stephentoub @ahsonkhan you both asked for that. I have tested that very carefully (I added new library to CoreFX, new type, new method to existing type) and everything works fine
|
@MarcoRossignoli @benaadams could you also please take a look? Your opinion is very important to me. |
|
@stephentoub @ahsonkhan @MarcoRossignoli big thanks for the reviews! I have fixed all issues. @danmosemsft as soon as you provide your review and I fix the issues you find, we can merge it ;) |
|
I edited PR directly as I cannot make a PR against this PR in your fork.. feel free to revert. LGTM |
|
@danmosemsft I really like your changes, thanks! |
@stephentoub @danmosemsft @ahsonkhan this is my proposal for the new official CoreFX benchmarking workflow using performance repo.
The easiest way to view it is most probably via:
https://github.com/adamsitnik/performance/blob/corefxDocs/docs/benchmarking-workflow-corefx.md
PTAL ;)