Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[perf][nativeaot] Add Native AOT performance measurements for iOS #3145

Merged

Conversation

kotlarmilos
Copy link
Member

@kotlarmilos kotlarmilos commented Jul 18, 2023

This PR introduces Native AOT startup and SOD measurements for the Maui apps. It also adds the Xamarin performance scenarios. Once the PR is merged, the performance dashboard should be expanded with Mono and Native AOT measurements.

@kotlarmilos kotlarmilos added the enhancement New feature or request label Jul 18, 2023
@kotlarmilos kotlarmilos self-assigned this Jul 18, 2023
cincuranet
cincuranet previously approved these changes Jul 19, 2023
@kotlarmilos
Copy link
Member Author

kotlarmilos commented Jul 19, 2023

Xamarin startup job failed due to incorrect package name in https://dev.azure.com/dnceng/internal/_build/results?buildId=2224727&view=results.

We will hopefully get the green CI in https://dev.azure.com/dnceng/internal/_build/results?buildId=2225094&view=results.

cincuranet
cincuranet previously approved these changes Jul 19, 2023
LoopedBard3
LoopedBard3 previously approved these changes Jul 19, 2023
Copy link
Member

@LoopedBard3 LoopedBard3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

cincuranet
cincuranet previously approved these changes Jul 20, 2023
@kotlarmilos
Copy link
Member Author

The perf tests have passed and a failure tracked in #3148 shouldn't be related.

@kotlarmilos kotlarmilos enabled auto-merge (squash) July 20, 2023 09:07
@cincuranet
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@cincuranet
Copy link
Contributor

After talking with @kotlarmilos, the failures should be unrelated, merging.

@cincuranet cincuranet disabled auto-merge July 21, 2023 09:12
@cincuranet cincuranet merged commit e5ca99f into dotnet:main Jul 21, 2023
19 of 30 checks passed
@kotlarmilos
Copy link
Member Author

Thanks. If it starts happening on the CI, we will act accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants