port TypeDescriptor benchmarks

[adamsitnik]

Fixes #48

This an excellent example why benchmarks MUST NOT contain any Asserts. I have ported the benchmarks and removed the asserts and BDN reported 1/7 of the time reported by xunit-performance.

I was shocked!

And then I used ILSpy to see what Assert was being used in the benchmark. The one from full xunit framework ;)

using (iteration.StartMeasurement())
    for (int i = 0; i < innerIterations; i++)
    {
        TypeConverter converter = TypeDescriptor.GetConverter(typeToConvert);
        Assert.NotNull(converter);
        Assert.Equal(expectedConverter, converter.GetType());
        Assert.True(converter.CanConvertTo(typeof(string)));
    }

So Asserts were 6/7 of the benchmarked time ;)

I did not have to port the Asserts to CoreFX because they are already there (each case has it's own test class)

Method	typeToConvert	expectedConverter	Mean	Error	StdDev	Median	Min	Max	Gen 0	Allocated
GetConverter	ClassIDerived	IBaseConverter	19.54 us	1.2412 us	1.4294 us	18.99 us	18.21 us	22.86 us	0.5833	3.91 KB
GetConverter	ClassWithNoConverter	TypeConverter	17.92 us	0.3542 us	0.3637 us	17.70 us	17.56 us	18.46 us	0.5910	3.91 KB
GetConverter	DerivedClass	DerivedClassConverter	26.54 us	1.6099 us	1.7894 us	25.61 us	24.33 us	30.00 us	0.5692	3.91 KB
GetConverter	IDerived	IBaseConverter	15.97 us	0.3967 us	0.4409 us	15.74 us	15.61 us	16.84 us	0.5934	3.91 KB
GetConverter	SomeEnum	EnumConverter	34.05 us	0.7000 us	0.7188 us	33.55 us	33.37 us	35.04 us	0.5896	3.91 KB
GetConverter	Enum	EnumConverter	27.20 us	0.6635 us	0.6813 us	26.97 us	26.82 us	29.44 us	0.5744	3.91 KB
GetConverter	Guid	GuidConverter	27.25 us	0.5298 us	0.5203 us	26.94 us	26.82 us	28.03 us	0.5000	3.91 KB
GetConverter	Int32	Int32Converter	27.22 us	0.5965 us	0.6383 us	26.90 us	26.72 us	28.86 us	0.6033	3.91 KB
GetConverter	SomeValueType?	NullableConverter	25.83 us	1.4700 us	1.6929 us	25.29 us	24.38 us	29.72 us	0.5379	3.91 KB
GetConverter	Int32?	NullableConverter	25.03 us	1.1559 us	1.2368 us	24.47 us	24.28 us	28.14 us	0.5521	3.91 KB
GetConverter	String	StringConverter	18.87 us	0.5419 us	0.5799 us	18.83 us	18.31 us	20.12 us	0.5704	3.91 KB

I also removed duplicated test cases, which were benchmarking same execiton path.

/cc @jorive

[jorive]

// [](start = 86, length = 2)

Should we remove this and start a fresh/clean benchmark? #Closed

[adamsitnik]

You mean the expectedConverter argument?

[adamsitnik]

Or in general?

[jorive]

In this case, the expectedConverter unused variable. #Closed

[jorive]

But, this would be a good opportunity to start a cleaner/newer benchmark too. #Closed

[adamsitnik]

But, this would be a good opportunity to start a cleaner/newer benchmark too.

hmm, since after removing the Asserts from the benchmark the time is 1/7 of what it was before, I can remove this argument and rename the benchmark

[adamsitnik]

@jorive I have removed the unused argument and removed the inner iteration count to let BDN do the job (it's a new benchmark after rename so I could do that)

[jorive]