Suppress CA2022 warnings in VB code #9570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewnoakes
added
the
Feature-Resource-Designer
|
/azp run |
smitpatel
approved these changes
Oct 28, 2024
|
/azp run |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
These warnings are helpful in general. They flag apparently incorrect use of `Stream.Read`, where the return value is unused. In the abstract, reading from a stream into a buffer is not guaranteed to return all the bytes requested, as those bytes may not yet be available. The cases covered by these three diagnostics are all in very old VB code, which hasn't been touched in ~15 years. My investigation suggests that all usages operate on `MemoryStream` which will actually always return the bytes you request. I feel it's less risky to just suppress these warnings rather than trying to fix them.
drewnoakes
force-pushed
the
suppress-warnings
branch
from
dcb3023 to
065ae1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These warnings are helpful in general. They flag apparently incorrect use of
Stream.Read, where the return value is unused. In the abstract, reading from a stream into a buffer is not guaranteed to return all the bytes requested, as those bytes may not yet be available.The cases covered by these three diagnostics are all in very old VB code, which hasn't been touched in ~15 years. My investigation suggests that all usages operate on
MemoryStreamwhich will actually always return the bytes you request.I feel it's less risky to just suppress these warnings rather than trying to fix them.
With these suppressions we are back to having no warnings during rebuild.
dotnet/roslyn-analyzers#7208
Microsoft Reviewers: Open in CodeFlow