-
Notifications
You must be signed in to change notification settings - Fork 191
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Render more TagHelper code at design time.
- This is a pre-requisite to properly warnings users about TagHelpers in code blocks. With this change VS indicates that there's an asynchronous operation happening in a code block but because the code is auto-generated it happens behind the scenes and therefore always gets logged as a line 1 error (unusable). Therefore, to fix this issue there will be a partner PR that will go out in AspNetCore that adds analyzer errors for cases where `__tagHelperRunner.RunAsync` exists in code blocks that do not return `Task` and are not marked with `async` properly. - Updated test files to reflect the new TagHelper codegen at design time. - Note: This doesn't solve the `~/` case that will be in a follow up PR. dotnet/aspnetcore#8630
- Loading branch information
1 parent
0cbfa9b
commit 17af3ef
Showing
122 changed files
with
786 additions
and
364 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 4 additions & 4 deletions
8
...ationTests/CodeGenerationIntegrationTest/ModelExpressionTagHelper_DesignTime.mappings.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,20 +1,20 @@ | ||
Source Location: (7:0,7 [8] TestFiles/IntegrationTests/CodeGenerationIntegrationTest/ModelExpressionTagHelper.cshtml) | ||
|DateTime| | ||
Generated Location: (870:21,0 [8] ) | ||
Generated Location: (1278:26,0 [8] ) | ||
|DateTime| | ||
|
||
Source Location: (33:2,14 [29] TestFiles/IntegrationTests/CodeGenerationIntegrationTest/ModelExpressionTagHelper.cshtml) | ||
|"InputTestTagHelper, AppCode"| | ||
Generated Location: (1180:31,37 [29] ) | ||
Generated Location: (1588:36,37 [29] ) | ||
|"InputTestTagHelper, AppCode"| | ||
|
||
Source Location: (83:4,17 [4] TestFiles/IntegrationTests/CodeGenerationIntegrationTest/ModelExpressionTagHelper.cshtml) | ||
|Date| | ||
Generated Location: (1897:49,102 [4] ) | ||
Generated Location: (2305:54,102 [4] ) | ||
|Date| | ||
|
||
Source Location: (111:5,18 [5] TestFiles/IntegrationTests/CodeGenerationIntegrationTest/ModelExpressionTagHelper.cshtml) | ||
|Model| | ||
Generated Location: (2251:57,94 [5] ) | ||
Generated Location: (2735:63,94 [5] ) | ||
|Model| | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 5 additions & 5 deletions
10
...TestFiles/IntegrationTests/CodeGenerationIntegrationTest/Sections_DesignTime.mappings.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,29 +1,29 @@ | ||
Source Location: (7:0,7 [8] TestFiles/IntegrationTests/CodeGenerationIntegrationTest/Sections.cshtml) | ||
|DateTime| | ||
Generated Location: (838:21,0 [8] ) | ||
Generated Location: (1246:26,0 [8] ) | ||
|DateTime| | ||
|
||
Source Location: (33:2,14 [29] TestFiles/IntegrationTests/CodeGenerationIntegrationTest/Sections.cshtml) | ||
|"InputTestTagHelper, AppCode"| | ||
Generated Location: (1132:31,37 [29] ) | ||
Generated Location: (1540:36,37 [29] ) | ||
|"InputTestTagHelper, AppCode"| | ||
|
||
Source Location: (152:10,9 [8] TestFiles/IntegrationTests/CodeGenerationIntegrationTest/Sections.cshtml) | ||
|Section1| | ||
Generated Location: (1400:41,22 [8] ) | ||
Generated Location: (1808:46,22 [8] ) | ||
|Section1| | ||
|
||
Source Location: (68:4,2 [46] TestFiles/IntegrationTests/CodeGenerationIntegrationTest/Sections.cshtml) | ||
| | ||
Layout = "_SectionTestLayout.cshtml"; | ||
| | ||
Generated Location: (1904:58,2 [46] ) | ||
Generated Location: (2312:63,2 [46] ) | ||
| | ||
Layout = "_SectionTestLayout.cshtml"; | ||
| | ||
|
||
Source Location: (222:12,21 [4] TestFiles/IntegrationTests/CodeGenerationIntegrationTest/Sections.cshtml) | ||
|Date| | ||
Generated Location: (2367:68,102 [4] ) | ||
Generated Location: (2775:73,102 [4] ) | ||
|Date| | ||
|
Oops, something went wrong.