Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten up the DotNet.ReproducibleBuilds package props file. #11

Merged
merged 3 commits into from
Aug 30, 2024

Conversation

AraHaan
Copy link
Member

@AraHaan AraHaan commented Oct 21, 2021

This should make it easier to edit it in the future as well.

Fixes #12.

@AraHaan AraHaan marked this pull request as ready for review October 21, 2021 03:30
@AraHaan AraHaan changed the title Shorten up the package build props file. Shorten up the DotNet.ReproducibleBuilds package props file. Oct 21, 2021
@AraHaan
Copy link
Member Author

AraHaan commented Jul 2, 2022

cc @clairernovotny, @baronfel does this look good? I know it could be shortened more but I figured having it this way would make it much more easier to read.

This should make it easier to edit it in the future as well.
@MattKotsenas MattKotsenas self-assigned this Aug 29, 2024
baronfel added a commit that referenced this pull request Aug 30, 2024
…tegrationBuild (#49)

This adds test coverage so that we can merge #11 / #12.
@MattKotsenas MattKotsenas requested a review from a team as a code owner August 30, 2024 21:30
Copy link
Member

@MattKotsenas MattKotsenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Sorry this took so long :)

@MattKotsenas MattKotsenas merged commit 94faeb1 into dotnet:main Aug 30, 2024
3 checks passed
@AraHaan AraHaan deleted the patch-1 branch September 6, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shorten up props file to DotNet.ReproducibleBuilds package.
3 participants