Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for package #47

Merged
merged 4 commits into from
Aug 27, 2024

Conversation

MattKotsenas
Copy link
Member

@MattKotsenas MattKotsenas commented Aug 27, 2024

In preparation for #46, add some test to validate the current package behavior. This doesn't test everything; future PRs should ensure the code they're changing is tested.

The test flow is as follows:

  1. Include DotNet.ReproducibleBuilds's own .props and .targets files into the test project's output
  2. Create a temp directory
  3. Create a {project}.*.props and {project}.*.targets file in the obj/ folder so that the .NET SDK will import the props and targets at the correct time (this is basically to do a NuGet restore of the project without needing to create the package or deal with package resolution)
  4. Create a temp project and assert the behavior

Copy link
Member

@baronfel baronfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, no notes.

I really like that library - might have to bug @jeffkl and see if we can get it added to feeds that the SDK uses so we can migrate off our home-grown stuff :D

@baronfel baronfel merged commit e0ee68a into dotnet:main Aug 27, 2024
3 checks passed
@MattKotsenas MattKotsenas deleted the feature/repositorybranch-net9 branch August 27, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants