[Performance] Improve UseValidPlatformString (CA1418) performance (#6867

)
dotnet · Sep 12, 2023 · 837c22a · 837c22a
1 parent ff698b7
commit 837c22a
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 2 deletions.
diff --git a/src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/InteropServices/UseValidPlatformString.cs b/src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/InteropServices/UseValidPlatformString.cs
@@ -152,8 +152,8 @@ static bool NameAndParametersValid(IMethodSymbol method) =>
 
         private static void AnalyzeOperation(IOperation operation, OperationAnalysisContext context, PooledDictionary<string, int> knownPlatforms)
         {
-            if (operation is IInvocationOperation invocation &&
-                methodNames.Contains(invocation.TargetMethod.Name) &&
+            var invocation = (IInvocationOperation)operation;
+            if (methodNames.Contains(invocation.TargetMethod.Name) &&
                 invocation.Arguments.Length > 0 &&
                 invocation.Arguments[0].Value is { } argument &&
                 argument.ConstantValue.HasValue &&

diff --git a/src/Utilities/Compiler/Extensions/ISymbolExtensions.cs b/src/Utilities/Compiler/Extensions/ISymbolExtensions.cs
@@ -649,6 +649,31 @@ public static IEnumerable<AttributeData> GetAttributes(this ISymbol symbol, para
             return symbol.GetAttributes(attributesToMatch: attributeTypesToMatch);
         }
 
+        #region "Overloads to avoid array allocations"
+        public static IEnumerable<AttributeData> GetAttributes(this ISymbol symbol, INamedTypeSymbol? attributeTypeToMatch1)
+        {
+            foreach (var attribute in symbol.GetAttributes())
+            {
+                if (SymbolEqualityComparer.Default.Equals(attribute.AttributeClass, attributeTypeToMatch1))
+                {
+                    yield return attribute;
+                }
+            }
+        }
+
+        public static IEnumerable<AttributeData> GetAttributes(this ISymbol symbol, INamedTypeSymbol? attributeTypeToMatch1, INamedTypeSymbol? attributeTypeToMatch2)
+        {
+            foreach (var attribute in symbol.GetAttributes())
+            {
+                if (SymbolEqualityComparer.Default.Equals(attribute.AttributeClass, attributeTypeToMatch1) ||
+                    SymbolEqualityComparer.Default.Equals(attribute.AttributeClass, attributeTypeToMatch2))
+                {
+                    yield return attribute;
+                }
+            }
+        }
+        #endregion
+
         public static bool HasAnyAttribute(this ISymbol symbol, IEnumerable<INamedTypeSymbol> attributesToMatch)
         {
             return symbol.GetAttributes(attributesToMatch).Any();