Remove CA2109 (#5974)

dotnet · Dec 13, 2022 · 932604d · 932604d
1 parent fde4933
commit 932604d
Show file tree

Hide file tree

Showing 8 changed files with 6 additions and 408 deletions.
diff --git a/...crosoft.CodeQuality.Analyzers/QualityGuidelines/CSharpReviewVisibleEventHandlers.Fixer.cs b/...crosoft.CodeQuality.Analyzers/QualityGuidelines/CSharpReviewVisibleEventHandlers.Fixer.cs
diff --git a/src/NetAnalyzers/Core/AnalyzerReleases.Unshipped.md b/src/NetAnalyzers/Core/AnalyzerReleases.Unshipped.md
@@ -10,3 +10,9 @@ CA1512 | Maintainability | Info | UseExceptionThrowHelpers, [Documentation](http
 CA1513 | Maintainability | Info | UseExceptionThrowHelpers, [Documentation](https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1513)
 CA1856 | Performance | Error | ConstantExpectedAnalyzer, [Documentation](https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1856)
 CA1857 | Performance | Warning | ConstantExpectedAnalyzer, [Documentation](https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1857)
+
+### Removed Rules
+
+Rule ID | Category | Severity | Notes
+--------|----------|----------|-------
+CA2109 | Security | Disabled | ReviewVisibleEventHandlersAnalyzer, [Documentation](https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2109)
diff --git a/...ore/Microsoft.CodeQuality.Analyzers/QualityGuidelines/ReviewVisibleEventHandlers.Fixer.cs b/...ore/Microsoft.CodeQuality.Analyzers/QualityGuidelines/ReviewVisibleEventHandlers.Fixer.cs
diff --git a/...zers/Core/Microsoft.CodeQuality.Analyzers/QualityGuidelines/ReviewVisibleEventHandlers.cs b/...zers/Core/Microsoft.CodeQuality.Analyzers/QualityGuidelines/ReviewVisibleEventHandlers.cs
diff --git a/src/NetAnalyzers/Microsoft.CodeAnalysis.NetAnalyzers.md b/src/NetAnalyzers/Microsoft.CodeAnalysis.NetAnalyzers.md
@@ -1860,18 +1860,6 @@ A platform invoke member allows partially trusted callers, has a string paramete
 |CodeFix|True|
 ---
 
-## [CA2109](https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2109): Review visible event handlers
-
-A public or protected event-handling method was detected. Event-handling methods should not be exposed unless absolutely necessary.
-
-|Item|Value|
-|-|-|
-|Category|Security|
-|Enabled|False|
-|Severity|Warning|
-|CodeFix|False|
----
-
 ## [CA2119](https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2119): Seal methods that satisfy private interfaces
 
 An inheritable public type provides an overridable method implementation of an internal (Friend in Visual Basic) interface. To fix a violation of this rule, prevent the method from being overridden outside the assembly.

diff --git a/src/NetAnalyzers/Microsoft.CodeAnalysis.NetAnalyzers.sarif b/src/NetAnalyzers/Microsoft.CodeAnalysis.NetAnalyzers.sarif
@@ -3361,27 +3361,6 @@
             ]
           }
         },
-        "CA2109": {
-          "id": "CA2109",
-          "shortDescription": "Review visible event handlers",
-          "fullDescription": "A public or protected event-handling method was detected. Event-handling methods should not be exposed unless absolutely necessary.",
-          "defaultLevel": "warning",
-          "helpUri": "https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2109",
-          "properties": {
-            "category": "Security",
-            "isEnabledByDefault": false,
-            "typeName": "ReviewVisibleEventHandlersAnalyzer",
-            "languages": [
-              "C#",
-              "Visual Basic"
-            ],
-            "tags": [
-              "PortedFromFxCop",
-              "Telemetry",
-              "EnabledRuleInAggressiveMode"
-            ]
-          }
-        },
         "CA2119": {
           "id": "CA2119",
           "shortDescription": "Seal methods that satisfy private interfaces",