Skip to content

Commit

Permalink
Add tracking issue in comments
Browse files Browse the repository at this point in the history
  • Loading branch information
mavasani committed Dec 22, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
1 parent dc04897 commit cd01f06
Showing 6 changed files with 16 additions and 16 deletions.
4 changes: 2 additions & 2 deletions .editorconfig
Original file line number Diff line number Diff line change
@@ -293,10 +293,10 @@ dotnet_diagnostic.CA1711.severity = suggestion
# CA1309: Use ordinal string comparison
dotnet_diagnostic.CA1309.severity = suggestion

# CA1305: Pass IFormatProvider - TODO: File an issue to fix or suppress CA1305 violations in the repo.
# CA1305: Pass IFormatProvider - https://github.com/dotnet/roslyn-analyzers/issues/6379
dotnet_diagnostic.CA1305.severity = suggestion

# CA1851: Possible multiple enumerations of 'IEnumerable' collection - TODO: File an issue to fix or suppress CA1851 violations in the repo.
# CA1851: Possible multiple enumerations of 'IEnumerable' collection - https://github.com/dotnet/roslyn-analyzers/issues/6379
dotnet_diagnostic.CA1851.severity = suggestion

### Configuration for PublicAPI analyzers executed on this repo ###
Original file line number Diff line number Diff line change
@@ -10,7 +10,7 @@ namespace Microsoft.CodeQuality.Analyzers.QualityGuidelines.AvoidMultipleEnumera
/// 2. An operation returns deferred type.
/// 3. A set of <see cref="AbstractLocation"/>, represent all the possible value source locations.
/// </summary>
#pragma warning disable CA1040 // Avoid empty interfaces
#pragma warning disable CA1040 // Avoid empty interfaces - https://github.com/dotnet/roslyn-analyzers/issues/6379
internal interface IDeferredTypeEntity
#pragma warning restore CA1040 // Avoid empty interfaces
{
Original file line number Diff line number Diff line change
@@ -28,7 +28,7 @@ private class Versions
{
public Version? Obsoleted { get; set; }
public string? ObsoletedMessage { get; set; }
#pragma warning disable CA1056 // URI-like properties should not be strings
#pragma warning disable CA1056 // URI-like properties should not be strings - https://github.com/dotnet/roslyn-analyzers/issues/6379
public string? ObsoletedUrl { get; set; }
#pragma warning restore CA1056 // URI-like properties should not be strings
public Version? SupportedFirst { get; set; }
Original file line number Diff line number Diff line change
@@ -2226,7 +2226,7 @@ static void AddOrUpdateSupportedAttribute(Versions attributes, Version version)
return null;
}

#pragma warning disable CA1055 // URI-like return values should not be strings
#pragma warning disable CA1055 // URI-like return values should not be strings - https://github.com/dotnet/roslyn-analyzers/issues/6379
private static string? PopulateUrl(AttributeData attribute)
#pragma warning restore CA1055 // URI-like return values should not be strings
{
Original file line number Diff line number Diff line change
@@ -52,7 +52,7 @@ private sealed class UnmanagedHelper<T> where T : unmanaged
return null;
}

#pragma warning disable CA1000 // Do not declare static members on generic types - TODO: file a tracking issue to fix these CA1000 violations
#pragma warning disable CA1000 // Do not declare static members on generic types - https://github.com/dotnet/roslyn-analyzers/issues/6379
public static bool TryCreate(IParameterSymbol parameterSymbol, AttributeData attributeData, T typeMin, T typeMax, [NotNullWhen(true)] out ConstantExpectedParameter? parameter)
=> Instance.TryCreate(parameterSymbol, attributeData, typeMin, typeMax, out parameter);
public static bool Validate(IParameterSymbol parameterSymbol, AttributeData attributeData, T typeMin, T typeMax, DiagnosticHelper diagnosticHelper, out ImmutableArray<Diagnostic> diagnostics)
20 changes: 10 additions & 10 deletions src/Tools/PerfDiff/BDN/BenchmarkDotNetDiffer.cs
Original file line number Diff line number Diff line change
@@ -35,8 +35,8 @@ public static class BenchmarkDotNetDiffer

if (!notSame.Any())
{
#pragma warning disable CA1848 // For improved performance, use the LoggerMessage delegates instead of calling 'LoggerExtensions.LogInformation(ILogger, string?, params object?[])'
#pragma warning disable CA2254 // The logging message template should not vary between calls to 'LoggerExtensions.LogInformation(ILogger, string?, params object?[])'
#pragma warning disable CA1848 // For improved performance, use the LoggerMessage delegates instead of calling 'LoggerExtensions.LogInformation(ILogger, string?, params object?[])' - https://github.com/dotnet/roslyn-analyzers/issues/6379
#pragma warning disable CA2254 // The logging message template should not vary between calls to 'LoggerExtensions.LogInformation(ILogger, string?, params object?[])' - https://github.com/dotnet/roslyn-analyzers/issues/6379
logger.LogInformation($"No differences found between the benchmark results with threshold {testThreshold}.");
#pragma warning restore CA2254 // The logging message template should not vary between calls to 'LoggerExtensions.LogInformation(ILogger, string?, params object?[])'
#pragma warning restore CA1848 // For improved performance, use the LoggerMessage delegates instead of calling 'LoggerExtensions.LogInformation(ILogger, string?, params object?[])'
@@ -56,16 +56,16 @@ public static class BenchmarkDotNetDiffer
if (betterCount > 0)
{
var betterGeoMean = Math.Pow(10, better.Skip(1).Aggregate(Math.Log10(GetRatio(better.First())), (x, y) => x + Math.Log10(GetRatio(y))) / better.Count());
#pragma warning disable CA1848 // For improved performance, use the LoggerMessage delegates instead of calling 'LoggerExtensions.LogInformation(ILogger, string?, params object?[])'
#pragma warning disable CA2254 // The logging message template should not vary between calls to 'LoggerExtensions.LogInformation(ILogger, string?, params object?[])'
#pragma warning disable CA1848 // For improved performance, use the LoggerMessage delegates instead of calling 'LoggerExtensions.LogInformation(ILogger, string?, params object?[])' - https://github.com/dotnet/roslyn-analyzers/issues/6379
#pragma warning disable CA2254 // The logging message template should not vary between calls to 'LoggerExtensions.LogInformation(ILogger, string?, params object?[])' - https://github.com/dotnet/roslyn-analyzers/issues/6379
logger.LogInformation($"better: {betterCount}, geomean: {betterGeoMean:F3}%");
#pragma warning restore CA2254 // The logging message template should not vary between calls to 'LoggerExtensions.LogInformation(ILogger, string?, params object?[])'
#pragma warning restore CA1848 // For improved performance, use the LoggerMessage delegates instead of calling 'LoggerExtensions.LogInformation(ILogger, string?, params object?[])'
foreach (var (betterId, betterBaseResult, betterDiffResult, conclusion) in worse)
{
var mean = GetRatio(conclusion, betterBaseResult, betterDiffResult);
#pragma warning disable CA1848 // For improved performance, use the LoggerMessage delegates instead of calling 'LoggerExtensions.LogInformation(ILogger, string?, params object?[])'
#pragma warning disable CA2254 // The logging message template should not vary between calls to 'LoggerExtensions.LogInformation(ILogger, string?, params object?[])'
#pragma warning disable CA1848 // For improved performance, use the LoggerMessage delegates instead of calling 'LoggerExtensions.LogInformation(ILogger, string?, params object?[])' - https://github.com/dotnet/roslyn-analyzers/issues/6379
#pragma warning disable CA2254 // The logging message template should not vary between calls to 'LoggerExtensions.LogInformation(ILogger, string?, params object?[])' - https://github.com/dotnet/roslyn-analyzers/issues/6379
logger.LogInformation($"' test: '{betterId}' tool '{mean:F3}' times less");
#pragma warning restore CA2254 // The logging message template should not vary between calls to 'LoggerExtensions.LogInformation(ILogger, string?, params object?[])'
#pragma warning restore CA1848 // For improved performance, use the LoggerMessage delegates instead of calling 'LoggerExtensions.LogInformation(ILogger, string?, params object?[])'
@@ -75,16 +75,16 @@ public static class BenchmarkDotNetDiffer
if (worseCount > 0)
{
var worseGeoMean = Math.Pow(10, worse.Skip(1).Aggregate(Math.Log10(GetRatio(worse.First())), (x, y) => x + Math.Log10(GetRatio(y))) / worse.Count());
#pragma warning disable CA1848 // For improved performance, use the LoggerMessage delegates instead of calling 'LoggerExtensions.LogInformation(ILogger, string?, params object?[])'
#pragma warning disable CA2254 // The logging message template should not vary between calls to 'LoggerExtensions.LogInformation(ILogger, string?, params object?[])'
#pragma warning disable CA1848 // For improved performance, use the LoggerMessage delegates instead of calling 'LoggerExtensions.LogInformation(ILogger, string?, params object?[])' - https://github.com/dotnet/roslyn-analyzers/issues/6379
#pragma warning disable CA2254 // The logging message template should not vary between calls to 'LoggerExtensions.LogInformation(ILogger, string?, params object?[])' - https://github.com/dotnet/roslyn-analyzers/issues/6379
logger.LogInformation($"' worse: {worseCount}, geomean: {worseGeoMean:F3}%");
#pragma warning restore CA2254 // The logging message template should not vary between calls to 'LoggerExtensions.LogInformation(ILogger, string?, params object?[])'
#pragma warning restore CA1848 // For improved performance, use the LoggerMessage delegates instead of calling 'LoggerExtensions.LogInformation(ILogger, string?, params object?[])'
foreach (var (worseId, worseBaseResult, worseDiffResult, conclusion) in worse)
{
var mean = GetRatio(conclusion, worseBaseResult, worseDiffResult);
#pragma warning disable CA1848 // For improved performance, use the LoggerMessage delegates instead of calling 'LoggerExtensions.LogInformation(ILogger, string?, params object?[])'
#pragma warning disable CA2254 // The logging message template should not vary between calls to 'LoggerExtensions.LogInformation(ILogger, string?, params object?[])'
#pragma warning disable CA1848 // For improved performance, use the LoggerMessage delegates instead of calling 'LoggerExtensions.LogInformation(ILogger, string?, params object?[])' - https://github.com/dotnet/roslyn-analyzers/issues/6379
#pragma warning disable CA2254 // The logging message template should not vary between calls to 'LoggerExtensions.LogInformation(ILogger, string?, params object?[])' - https://github.com/dotnet/roslyn-analyzers/issues/6379
logger.LogInformation($"' test: '{worseId}' took '{mean:F3}' times longer");
#pragma warning restore CA2254 // The logging message template should not vary between calls to 'LoggerExtensions.LogInformation(ILogger, string?, params object?[])'
#pragma warning restore CA1848 // For improved performance, use the LoggerMessage delegates instead of calling 'LoggerExtensions.LogInformation(ILogger, string?, params object?[])'

0 comments on commit cd01f06

Please sign in to comment.