Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Are "CA2229 and CA2237" analyzers relevant beginning with .NET 8 Preview 4 #7026

Open
kartheekp-ms opened this issue Nov 9, 2023 · 1 comment
Open

Are "CA2229 and CA2237" analyzers relevant beginning with .NET 8 Preview 4 #7026

kartheekp-ms opened this issue Nov 9, 2023 · 1 comment
Assignees
@buyaa-n
Labels
Area-Microsoft.CodeAnalysis.NetAnalyzers Questions
Milestone
Unknown

Comments

@kartheekp-ms
Copy link

kartheekp-ms commented Nov 9, 2023 •
edited
Loading

Analyzer

Diagnostic ID(s):

  • CA2237: Mark ISerializable types with SerializableAttribute
  • CA2229: Implement serialization constructors

Analyzer source

SDK: Built-in CA analyzers in .NET 5 SDK or later

Version: SDK 5.0.100

OR

NuGet Package: Microsoft.CodeAnalysis.NetAnalyzers

Version: 5.0.3 (Latest)

Describe the bug

Are CA2229 and CA2237 analyzers relevant anymore given that the serialization constructor is marked as Obsolete beginning with .NET 8 Preview 4? Refer to dotnet/docs#34893 for more details.
@kartheekp-ms kartheekp-ms changed the title Is "CA2229: Implement serialization constructors" analyzer relevant beginning with .NET 8 Preview 4 Are "CA2229 and CA2237" analyzers relevant beginning with .NET 8 Preview 4 Nov 9, 2023
This was referenced Nov 9, 2023
Closed
Merged
@mavasani
Copy link
Contributor

mavasani commented Nov 9, 2023

#6911 removed CA2229. @buyaa-n to comment on CA2237

@mavasani mavasani added this to the Unknown milestone Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@buyaa-n buyaa-n

Labels
Area-Microsoft.CodeAnalysis.NetAnalyzers Questions
Projects
None yet
Milestone
Unknown
Development

No branches or pull requests
3 participants
@mavasani @buyaa-n @kartheekp-ms