Remove CA2229 Implement serialization constructors #6911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buyaa-n
requested review from
jeffhandley,
carlossanlop,
GrabYourPitchforks,
stephentoub and
mavasani
buyaa-n
commented
Sep 5, 2023
| isDataflowRule: false, | ||
| isEnabledByDefaultInFxCopAnalyzers: false);*/ | ||
|
|
||
| public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics { get; } = ImmutableArray<DiagnosticDescriptor>.Empty; |
There was a problem hiding this comment.
This and ImplementSerializationMethodsCorrectly.cs are not implemented and has empty C#, VB overloads and C#/VB Fixers with overloads, kind of unrelated, but has no effect, I can remove them separately if needed
Codecov Report
@@ Coverage Diff @@
## main #6911 +/- ##
========================================
Coverage 96.40% 96.40%
========================================
Files 1403 1396 -7
Lines 331173 330443 -730
Branches 10903 10891 -12
========================================
- Hits 319258 318560 -698
+ Misses 9182 9155 -27
+ Partials 2733 2728 -5 |
mavasani
reviewed
Sep 6, 2023
mavasani
approved these changes
Sep 6, 2023
|
/backport to release/8.0.1xx |
|
Started backporting to release/8.0.1xx: https://github.com/dotnet/roslyn-analyzers/actions/runs/6102469269 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CA2229:
Implement serialization constructorsconflicts with SYSLIB0051:Legacy serialization support APIs are obsolete. As Binary formatters are deprecated in .NET Core CA2229 is also out dated and can be removed.See more details from the issue: dotnet/runtime#90783
Fixes dotnet/runtime#90783
This PR: