Fix CA1805 assignment of default to nullable #3785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One more case found from dotnet/runtime. Code like: ```C# private int? _value = 0; ``` shouldn't warn, but it currently does.
Codecov Report
@@ Coverage Diff @@
## master #3785 +/- ##
=======================================
Coverage 95.78% 95.78%
=======================================
Files 1100 1100
Lines 246317 246319 +2
Branches 14622 14622
=======================================
+ Hits 235923 235931 +8
Misses 8603 8603
+ Partials 1791 1785 -6 |
mavasani
approved these changes
Jun 28, 2020
|
Thanks, @mavasani. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One more case found from dotnet/runtime. Code like:
shouldn't warn, but it currently does.
This is the last issue discovered in running the rule over dotnet/runtime:
dotnet/runtime#38410