Flag when platform specific type used as generic type parameter #4403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4403 +/- ##
========================================
Coverage 95.80% 95.81%
========================================
Files 1174 1174
Lines 267562 267805 +243
Branches 16097 16105 +8
========================================
+ Hits 256351 256601 +250
+ Misses 9145 9137 -8
- Partials 2066 2067 +1 |
|
@jeffhandley confirmed that we want it for 5.0.2xx and we have a separate issue for tracking inheritance related scenarios, I think this PR good to go now @mavasani please take another look |
mavasani
reviewed
Nov 4, 2020
...tAnalyzers/Core/Microsoft.NetCore.Analyzers/InteropServices/PlatformCompatibilityAnalyzer.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Nov 4, 2020
...tAnalyzers/Core/Microsoft.NetCore.Analyzers/InteropServices/PlatformCompatibilityAnalyzer.cs
Outdated
Show resolved
Hide resolved
buyaa-n
commented
Nov 4, 2020
...tAnalyzers/Core/Microsoft.NetCore.Analyzers/InteropServices/PlatformCompatibilityAnalyzer.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Nov 5, 2020
...tAnalyzers/Core/Microsoft.NetCore.Analyzers/InteropServices/PlatformCompatibilityAnalyzer.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Nov 5, 2020
...tAnalyzers/Core/Microsoft.NetCore.Analyzers/InteropServices/PlatformCompatibilityAnalyzer.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Nov 5, 2020
...tAnalyzers/Core/Microsoft.NetCore.Analyzers/InteropServices/PlatformCompatibilityAnalyzer.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Nov 5, 2020
...tAnalyzers/Core/Microsoft.NetCore.Analyzers/InteropServices/PlatformCompatibilityAnalyzer.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Nov 5, 2020
...tAnalyzers/Core/Microsoft.NetCore.Analyzers/InteropServices/PlatformCompatibilityAnalyzer.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Nov 5, 2020
...tAnalyzers/Core/Microsoft.NetCore.Analyzers/InteropServices/PlatformCompatibilityAnalyzer.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Nov 5, 2020
...tAnalyzers/Core/Microsoft.NetCore.Analyzers/InteropServices/PlatformCompatibilityAnalyzer.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Nov 5, 2020
.../UnitTests/Microsoft.NetCore.Analyzers/InteropServices/PlatformCompatibilityAnalyzerTests.cs
Show resolved
Hide resolved
mavasani
reviewed
Nov 5, 2020
...tAnalyzers/Core/Microsoft.NetCore.Analyzers/InteropServices/PlatformCompatibilityAnalyzer.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Nov 5, 2020
...tAnalyzers/Core/Microsoft.NetCore.Analyzers/InteropServices/PlatformCompatibilityAnalyzer.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Nov 5, 2020
...tAnalyzers/Core/Microsoft.NetCore.Analyzers/InteropServices/PlatformCompatibilityAnalyzer.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Nov 5, 2020
jeffhandley
reviewed
Nov 6, 2020
...ft.NetCore.Analyzers/InteropServices/PlatformCompatibilityAnalyzerTests.GuardedCallsTests.cs
Show resolved
Hide resolved
mavasani
reviewed
Nov 6, 2020
...tAnalyzers/Core/Microsoft.NetCore.Analyzers/InteropServices/PlatformCompatibilityAnalyzer.cs
Outdated
Show resolved
Hide resolved
buyaa-n
commented
Nov 7, 2020
| var containingSymbol = context.ContainingSymbol; | ||
| if (containingSymbol is IMethodSymbol method && method.IsAccessorMethod()) | ||
| { | ||
| containingSymbol = method.AssociatedSymbol; |
There was a problem hiding this comment.
As we are not adding parent attributes to the accessor methods so that it will not report a duplicate warning when the containing symbol had any attribute (for example property has no accessor level attribute but the entire property has attribute). But when the property getter or setter any statements inside it became the containing symbol for those statements. When accessors used as call site, as their attributes are not including the parent attributes call site attributes are incomplete and causing warnings. So here when accessor is the containing symbol change it to the AssociatedSymbol which is the real Property or Event which has complete attributes for call site
mavasani
approved these changes
Nov 7, 2020
|
Retargeted to master, as there is no any other change merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warn when platform-specific type used as generic type parameter, useful when a type created using reflections
Fixes #4362
Cherry-picked from #4390 to target
release\5.0.2xxbranch