Use package name suffix for property names used inside AddGlobalAnalyzerConfigForPackage target
#4489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use package name suffix for property names used inside `AddGlobalAnalyzerConfigForPackage` target. This prevents clashes between property values when executed in context of different analyzer packages.
Codecov Report
@@ Coverage Diff @@
## release/5.0.2xx #4489 +/- ##
================================================
Coverage 95.79% 95.79%
================================================
Files 1164 1164
Lines 264445 264445
Branches 15976 15976
================================================
+ Hits 253323 253330 +7
+ Misses 9099 9098 -1
+ Partials 2023 2017 -6 |
|
Merging as this is a trivial change needed to unblock package release. |
This was referenced Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents clashes between property values when executed in context of different analyzer packages. Found this issue while dogfooding the NetAnalyzers package, when also referencing another analyzer package produced from this repo.