New constant expected analyzer

src/NetAnalyzers/CSharp/Microsoft.NetCore.Analyzers/Performance/CSharpConstantExpectedAnalyzer.cs

@@ -0,0 +1,60 @@
+// Copyright (c) Microsoft.  All Rights Reserved.  Licensed under the MIT license.  See License.txt in the project root for license information.
+
+using System.Linq;
+using Microsoft.CodeAnalysis;
+using Microsoft.CodeAnalysis.CSharp;
+using Microsoft.CodeAnalysis.CSharp.Syntax;
+using Microsoft.CodeAnalysis.Diagnostics;
+using Microsoft.NetCore.Analyzers.Performance;
+
+namespace Microsoft.NetCore.CSharp.Analyzers.Performance
+{
+    [DiagnosticAnalyzer(LanguageNames.CSharp)]
+    internal sealed class CSharpConstantExpectedAnalyzer : ConstantExpectedAnalyzer
+    {
+        private static readonly CSharpDiagnosticHelper s_diagnosticHelper = new();
+        private readonly IdentifierNameSyntax _constantExpectedIdentifier = (IdentifierNameSyntax)SyntaxFactory.ParseName(ConstantExpected);
+        private readonly IdentifierNameSyntax _constantExpectedAttributeIdentifier = (IdentifierNameSyntax)SyntaxFactory.ParseName(ConstantExpectedAttribute);
+
+        protected override DiagnosticHelper Helper => s_diagnosticHelper;
+
+        protected override void RegisterAttributeSyntax(CompilationStartAnalysisContext context)
+        {
+            context.RegisterSyntaxNodeAction(context => OnAttributeNode(context), SyntaxKind.Attribute);
+        }
+        private void OnAttributeNode(SyntaxNodeAnalysisContext context)
+        {
+            var attributeSyntax = (AttributeSyntax)context.Node;
+            if (!attributeSyntax.Name.IsEquivalentTo(_constantExpectedIdentifier) && !attributeSyntax.Name.IsEquivalentTo(_constantExpectedAttributeIdentifier))
+            {
+                return;
+            }
+            var parameter = (ParameterSyntax)attributeSyntax.Parent.Parent;
+            var parameterSymbol = context.SemanticModel.GetDeclaredSymbol(parameter);
+
+            OnParameterWithConstantExpectedAttribute(parameterSymbol, context.ReportDiagnostic);
+        }
+
+        private sealed class CSharpDiagnosticHelper : DiagnosticHelper
+        {
+            private readonly IdentifierNameSyntax _constantExpectedMinIdentifier = (IdentifierNameSyntax)SyntaxFactory.ParseName("Min");
+            private readonly IdentifierNameSyntax _constantExpectedMaxIdentifier = (IdentifierNameSyntax)SyntaxFactory.ParseName("Max");
+
+            public override Location? GetMaxLocation(SyntaxNode attributeNode) => GetArgumentLocation(attributeNode, _constantExpectedMaxIdentifier);
+
+            public override Location? GetMinLocation(SyntaxNode attributeNode) => GetArgumentLocation(attributeNode, _constantExpectedMinIdentifier);
+
+            private static Location? GetArgumentLocation(SyntaxNode attributeNode, IdentifierNameSyntax targetNameSyntax)
+            {
+                var attributeSyntax = (AttributeSyntax)attributeNode;
+                if (attributeSyntax.ArgumentList is null)
+                {
+                    return null;
+                }
+                var targetArg = attributeSyntax.ArgumentList.Arguments.FirstOrDefault(arg => arg.NameEquals.Name.IsEquivalentTo(targetNameSyntax, true));
+                return targetArg?.GetLocation();
+            }
+        }
+    }
+}
+;

src/NetAnalyzers/Core/AnalyzerReleases.Unshipped.md

@@ -6,5 +6,7 @@ Rule ID | Category | Severity | Notes
 --------|----------|----------|-------
 CA1849 | Performance | Disabled | UseAsyncMethodInAsyncContext, [Documentation](https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1849)
 CA1850 | Performance | Info | PreferHashDataOverComputeHashAnalyzer, [Documentation](https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1850)
+CA1860 | Performance | Error | ConstantExpectedAnalyzer, [Documentation](https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1860)
+CA1861 | Performance | Warning | ConstantExpectedAnalyzer, [Documentation](https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1860)
 CA5404 | Security | Disabled | DoNotDisableTokenValidationChecks, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca5404)
 CA5405 | Security | Disabled | DoNotAlwaysSkipTokenValidationInDelegates, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca5405)

src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/MicrosoftNetCoreAnalyzersResources.resx

@@ -1834,4 +1834,40 @@
   <data name="UsesPreviewTypeParameterMessage" xml:space="preserve">
     <value>'{0}' uses the preview type '{1}' and needs to opt into preview features. See {2} for more information.</value>
   </data>
+  <data name="ConstantExpectedApplicationTitle" xml:space="preserve">
+    <value>Incorrect use of ConstantExpectedAttribute</value>
+  </data>
+  <data name="ConstantExpectedApplicationDescription" xml:space="preserve">
+    <value>ConstantExpectedAttribute is not applied correctly on the paramter.</value>
+  </data>
+  <data name="ConstantExpectedUsageTitle" xml:space="preserve">
+    <value>Constant is expected for the parameter</value>
+  </data>
+  <data name="ConstantExpectedUsageDescription" xml:space="preserve">
+    <value>The parameter expects a constant for optimal performance.</value>
+  </data>
+  <data name="ConstantExpectedNotSupportedMessage" xml:space="preserve">
+    <value>The '{0}' parameter is not supported for ConstantExpectedAttribute.</value>
+  </data>
+  <data name="ConstantExpectedIncompatibleConstantTypeMessage" xml:space="preserve">
+    <value>The '{0}' value is not compatible with parameter type of '{1}'.</value>
+  </data>
+  <data name="ConstantExpectedInvalidBoundsMessage" xml:space="preserve">
+    <value>The '{0}' value does not fit within the parameter value bounds of '{1}' to '{2}'.</value>
+  </data>
+  <data name="ConstantExpectedInvertedRangeMessage" xml:space="preserve">
+    <value>The Min and Max value are inverted.</value>
+  </data>
+  <data name="ConstantExpectedOutOfBoundsMessage" xml:space="preserve">
+    <value>The constant does not fit within the value bounds of '{0}' to '{1}'.</value>
+  </data>
+  <data name="ConstantExpectedInvalidMessage" xml:space="preserve">
+    <value>The constant is not of the same '{0}' type as the parameter</value>
+  </data>
+  <data name="ConstantExpectedNotConstantMessage" xml:space="preserve">
+    <value>The argument should be a constant for optimal performance.</value>
+  </data>
+  <data name="ConstantExpectedAttributExpectedMessage" xml:space="preserve">
+    <value>The ConstantExpectedAttribute expected for the parameter due to the interface/base method.</value>
+  </data>
 </root>