Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in RS0030 message: "Do not used banned APIs" -> "Do not use banned APIs" #6213

Merged

Conversation

sorensenmatias
Copy link
Contributor

Fix typo in RS0030 message: "Do not used banned APIs" -> "Do not use banned APIs"

@sorensenmatias sorensenmatias marked this pull request as ready for review October 19, 2022 12:07
@sorensenmatias sorensenmatias requested a review from a team as a code owner October 19, 2022 12:07
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM but I expect some build issue on localization files as the content is still appearing as "translated". Did you run msbuild /t:pack /v:m as recommended when opening the PR?

Thanks for the contribution @sorensenmatias

@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #6213 (08bd10f) into main (f8ffc8f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6213      +/-   ##
==========================================
+ Coverage   96.04%   96.05%   +0.01%     
==========================================
  Files        1360     1364       +4     
  Lines      311858   313686    +1828     
  Branches    10048    10125      +77     
==========================================
+ Hits       299517   301322    +1805     
- Misses       9931     9944      +13     
- Partials     2410     2420      +10     

@sorensenmatias
Copy link
Contributor Author

@Evangelink Thanks! Yes I did run the dotnet msbuild /t:pack /v:m command, but it did not produce anything to commit.
I am not sure how I can progress this - can you help?

@Evangelink
Copy link
Member

@mavasani Is PR ok as-is or are we supposed to have the localization files translation status reset?

@Youssef1313
Copy link
Member

Youssef1313 commented Oct 31, 2022

Running pack didn't produce any changes because xlf files were manually modified. So, the UpdateXlf target can't really know that the state needs to be updated.

Merging the PR as-is might cause issues. The changes in xlf should be reverted, then dotnet msbuild /t:pack /v:m should be run.

@sorensenmatias
Copy link
Contributor Author

Thanks.
I reverted the changes to xlf files and pushed the commit, but running dotnet msbuild /t:pack /v:m still does not produce anything. What else is missing?

@Youssef1313
Copy link
Member

Sorry @sorensenmatias, it should be dotnet msbuild -t:pack -v:m

@sorensenmatias
Copy link
Contributor Author

@Youssef1313 Thanks, but running that instead still does not produce anything.

@Youssef1313
Copy link
Member

Do you see any errors?
What is the output of the command?

@Youssef1313
Copy link
Member

@sorensenmatias You can merge sorensenmatias#1 if you couldn't do it yourself locally, but it's definitely good to understand the problem you're having.

@sorensenmatias
Copy link
Contributor Author

@Youssef1313 Thanks a lot - it is merged.

@Youssef1313
Copy link
Member

@mavasani Can you take a look and merge please?

@mavasani mavasani merged commit f67947a into dotnet:main Dec 8, 2022
@github-actions github-actions bot added this to the vNext milestone Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants