-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo in RS0030 message: "Do not used banned APIs" -> "Do not use banned APIs" #6213
Fix typo in RS0030 message: "Do not used banned APIs" -> "Do not use banned APIs" #6213
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM but I expect some build issue on localization files as the content is still appearing as "translated". Did you run msbuild /t:pack /v:m
as recommended when opening the PR?
Thanks for the contribution @sorensenmatias
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6213 +/- ##
==========================================
+ Coverage 96.04% 96.05% +0.01%
==========================================
Files 1360 1364 +4
Lines 311858 313686 +1828
Branches 10048 10125 +77
==========================================
+ Hits 299517 301322 +1805
- Misses 9931 9944 +13
- Partials 2410 2420 +10 |
@Evangelink Thanks! Yes I did run the |
@mavasani Is PR ok as-is or are we supposed to have the localization files translation status reset? |
Running pack didn't produce any changes because Merging the PR as-is might cause issues. The changes in |
Thanks. |
Sorry @sorensenmatias, it should be |
@Youssef1313 Thanks, but running that instead still does not produce anything. |
Do you see any errors? |
@sorensenmatias You can merge sorensenmatias#1 if you couldn't do it yourself locally, but it's definitely good to understand the problem you're having. |
…empt2 UpdateXlf
@Youssef1313 Thanks a lot - it is merged. |
@mavasani Can you take a look and merge please? |
Fix typo in RS0030 message: "Do not used banned APIs" -> "Do not use banned APIs"