Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle conversion operation as operands of IThrowOperation #6304

Merged
merged 2 commits into from
Dec 8, 2022

Conversation

mavasani
Copy link
Contributor

@mavasani mavasani commented Dec 8, 2022

Fixes #6284

Starting C# 8.0, C# compiler wraps the thrown operation within an implicit conversion to System.Exception type.

@mavasani mavasani requested a review from Evangelink December 8, 2022 09:07
@mavasani mavasani requested a review from a team as a code owner December 8, 2022 09:07
@mavasani
Copy link
Contributor Author

mavasani commented Dec 8, 2022

@Youssef1313

@mavasani
Copy link
Contributor Author

mavasani commented Dec 8, 2022

@sharwell The github action seems to always label my PRs as Community :-)

@mavasani mavasani removed the Community label Dec 8, 2022
@Youssef1313
Copy link
Member

Youssef1313 commented Dec 8, 2022

@sharwell The github action seems to always label my PRs as Community :-)

And it doesn't label mine as Community #6295

@Youssef1313
Copy link
Member

@sharwell The github action seems to always label my PRs as Community :-)

I figured that out. The action isn't able to know that you are in dotnet organizations because you set it to private. If you want to make it public, you can set it here.

Meanwhile, I think the Action should still be able to handle private members correctly. It probably doesn't because it lacks permissions. I'll open a PR that might fix it.

@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #6304 (3b84a3d) into main (3bc91ee) will decrease coverage by 0.00%.
The diff coverage is 96.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6304      +/-   ##
==========================================
- Coverage   96.07%   96.07%   -0.01%     
==========================================
  Files        1367     1367              
  Lines      315337   315352      +15     
  Branches    10187    10187              
==========================================
+ Hits       302965   302976      +11     
- Misses       9939     9942       +3     
- Partials     2433     2434       +1     

Copy link
Member

@Youssef1313 Youssef1313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mavasani mavasani merged commit 1eb2caf into dotnet:main Dec 8, 2022
@mavasani mavasani deleted the FixThrowConversion branch December 8, 2022 12:37
@github-actions github-actions bot added this to the vNext milestone Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not effective - CA2200: Rethrow to preserve stack details
2 participants