-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle conversion operation as operands of IThrowOperation #6304
Conversation
@sharwell The github action seems to always label my PRs as |
I figured that out. The action isn't able to know that you are in dotnet organizations because you set it to private. If you want to make it public, you can set it here. Meanwhile, I think the Action should still be able to handle private members correctly. It probably doesn't because it lacks permissions. I'll open a PR that might fix it. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6304 +/- ##
==========================================
- Coverage 96.07% 96.07% -0.01%
==========================================
Files 1367 1367
Lines 315337 315352 +15
Branches 10187 10187
==========================================
+ Hits 302965 302976 +11
- Misses 9939 9942 +3
- Partials 2433 2434 +1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #6284
Starting C# 8.0, C# compiler wraps the thrown operation within an implicit conversion to
System.Exception
type.