Delete WinForms-specific unimplemented analyzers #6350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mavasani
approved these changes
Dec 14, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6350 +/- ##
=======================================
Coverage 96.08% 96.08%
=======================================
Files 1366 1362 -4
Lines 315512 315490 -22
Branches 10187 10187
=======================================
- Hits 303145 303137 -8
+ Misses 9934 9920 -14
Partials 2433 2433 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #545 and #408
In short, dotnet/runtime#79602 (comment) suggests that these analyzers should be implemented in dotnet/winforms.
If dotnet/winforms team decided not to implement these analyzers, we can reopen #545 and #408 and get these back when the implementation for them starts.