Don't import System when it's already imported by global using #6358
Conversation
Youssef1313
force-pushed
the
using-system
branch
from
c4934ee to
39b58fe
Compare
Youssef1313
force-pushed
the
using-system
branch
from
39b58fe to
1a36608
Compare
| @@ -30,12 +30,11 @@ namespace Microsoft.NetCore.Analyzers.Runtime | |||
| /// </summary> | |||
| public abstract class PreferStreamAsyncMemoryOverloadsFixer : CodeFixProvider | |||
| { | |||
| private static readonly SyntaxAnnotation s_asMemorySymbolAnnotation = new("SymbolId", "System.MemoryExtensions"); | |||
There was a problem hiding this comment.
This is quite an implementation detail on Roslyn. I have an API proposal to expose it in cleaner way. dotnet/roslyn#65041
|
@CyrusNajmabadi Looks like I got a repro here for the line ending issue. dotnet/roslyn#65081 Can you please take a look? Thanks! |
|
My bad. This is an extra line, not line ending difference. This is completely unrelated to dotnet/roslyn#65081. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6358 +/- ##
==========================================
+ Coverage 96.08% 96.11% +0.02%
==========================================
Files 1360 1361 +1
Lines 315522 316072 +550
Branches 10187 10187
==========================================
+ Hits 303173 303777 +604
+ Misses 9917 9865 -52
+ Partials 2432 2430 -2 |
|
and now ubuntu only failure related to end of lines 😄 |
|
@mavasani Failure here is a Roslyn bug that we have in other codefixes that uses Is it okay to disable the test on Linux? Any workaround you can think of? |
Yes, that sounds reasonable. I believe we have an attribute to execute tests only on Windows platform that is used by some tests. I can't recall if it exists only in Roslyn or also in this repo. |
It exists here and removal is tracked by #4586. |
Fixes #5652