Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file-local class test for CA1812 #6360

Merged
merged 1 commit into from
Dec 16, 2022

Conversation

ahmedabdelkabier
Copy link
Contributor

Fixes #6049

@ahmedabdelkabier ahmedabdelkabier requested a review from a team as a code owner December 15, 2022 18:05
Copy link
Member

@Youssef1313 Youssef1313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Merging #6360 (3983b32) into main (9e92aa9) will increase coverage by 0.00%.
The diff coverage is 87.50%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6360   +/-   ##
=======================================
  Coverage   96.08%   96.08%           
=======================================
  Files        1360     1360           
  Lines      315522   315530    +8     
  Branches    10187    10187           
=======================================
+ Hits       303173   303183   +10     
+ Misses       9917     9915    -2     
  Partials     2432     2432           

@mavasani mavasani merged commit 7af823a into dotnet:main Dec 16, 2022
@github-actions github-actions bot added this to the vNext milestone Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test for "CA1812: Avoid uninstantiated internal classes" including a file class
3 participants