Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tests to target .NET 7 #6364

Merged
merged 2 commits into from
Jan 10, 2023
Merged

Move tests to target .NET 7 #6364

merged 2 commits into from
Jan 10, 2023

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Dec 16, 2022

.NET Core 3.1 is out of support now.

It's also a pain for contributors working on Ubuntu as it seems 3.1 isn't supported in Ubuntu 22.04.

image

This change also (unintentionally) fixes #6316 for me.

@Youssef1313 Youssef1313 requested a review from a team as a code owner December 16, 2022 09:48
@Youssef1313
Copy link
Member Author

FYI @ahmedabdelkabier

@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Merging #6364 (8681ec1) into main (7af823a) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6364      +/-   ##
==========================================
- Coverage   96.08%   96.08%   -0.01%     
==========================================
  Files        1357     1357              
  Lines      315287   315243      -44     
  Branches    10184    10186       +2     
==========================================
- Hits       302951   302889      -62     
- Misses       9904     9916      +12     
- Partials     2432     2438       +6     

@mavasani
Copy link
Contributor

@sharwell @jmarolf Do you see any issues with this change?

@jmarolf jmarolf merged commit 3168c39 into dotnet:main Jan 10, 2023
@github-actions github-actions bot added this to the vNext milestone Jan 10, 2023
@Youssef1313 Youssef1313 deleted the net7-tests branch January 11, 2023 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All tests in Microsoft.CodeAnalysis.NetAnalyzers.UnitTests fail locally with FatalProtocolException
4 participants