Add RSxxxx diagnostic for compilation end diagnostic descriptors without CompilationEnd custom tag

[mavasani]

Closes #6282

[mavasani]

@Youssef1313 @Evangelink for review. Thanks!

[codecov]

Codecov Report

Merging #6397 (2a19c5b) into main (b7bb138) will increase coverage by 0.00%.
The diff coverage is 99.05%.

Additional details and impacted files

@@           Coverage Diff            @@
##             main    #6397    +/-   ##
========================================
  Coverage   96.11%   96.11%            
========================================
  Files        1361     1361            
  Lines      316031   316545   +514     
  Branches    10195    10214    +19     
========================================
+ Hits       303738   304244   +506     
- Misses       9861     9863     +2     
- Partials     2432     2438     +6     

[Youssef1313]

Does this work for DiagnosticDescriptorHelper.Create we have in this repo?

[Youssef1313]

LGTM (given a quick look)

[mavasani]

Does this work for DiagnosticDescriptorHelper.Create we have in this repo?

I think it should. Analyzing CustomTags argument is done by existing code in the analyzer. Even otherwise, I think we primarily care about analyzers outside this repo to benefit from this new warning.

[Youssef1313]

It looks like there is a violation in this repo?

roslyn-analyzers/src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/InteropServices/UseValidPlatformString.cs

Lines 90 to 91 in e378446

	context.RegisterCompilationEndAction(context => AnalyzeSymbol(context.ReportDiagnostic, context.Compilation.Assembly,
	supportedAttriubte, unsupportedAttribute, knownPlatforms, context.CancellationToken));

roslyn-analyzers/src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/InteropServices/UseValidPlatformString.cs

Lines 34 to 59 in e378446

	internal static readonly DiagnosticDescriptor UnknownPlatform = DiagnosticDescriptorHelper.Create(RuleId,
	s_localizableTitle,
	CreateLocalizableResourceString(nameof(UseValidPlatformStringUnknownPlatform)),
	DiagnosticCategory.Interoperability,
	RuleLevel.BuildWarning,
	description: s_localizableDescription,
	isPortedFxCopRule: false,
	isDataflowRule: false);
	internal static readonly DiagnosticDescriptor InvalidVersion = DiagnosticDescriptorHelper.Create(RuleId,
	s_localizableTitle,
	CreateLocalizableResourceString(nameof(UseValidPlatformStringInvalidVersion)),
	DiagnosticCategory.Interoperability,
	RuleLevel.BuildWarning,
	description: s_localizableDescription,
	isPortedFxCopRule: false,
	isDataflowRule: false);
	internal static readonly DiagnosticDescriptor NoVersion = DiagnosticDescriptorHelper.Create(RuleId,
	s_localizableTitle,
	CreateLocalizableResourceString(nameof(UseValidPlatformStringNoVersion)),
	DiagnosticCategory.Interoperability,
	RuleLevel.BuildWarning,
	description: s_localizableDescription,
	isPortedFxCopRule: false,
	isDataflowRule: false);

Though this one can't easily be caught as context.ReportDiagnostic isn't invoked, but rather captured as a method group and passed down few calls to report a diagnostic.

[mavasani]

It looks like there is a violation in this repo?

roslyn-analyzers/src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/InteropServices/UseValidPlatformString.cs

Lines 90 to 91 in e378446

	context.RegisterCompilationEndAction(context => AnalyzeSymbol(context.ReportDiagnostic, context.Compilation.Assembly,
	supportedAttriubte, unsupportedAttribute, knownPlatforms, context.CancellationToken));

roslyn-analyzers/src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/InteropServices/UseValidPlatformString.cs

Lines 34 to 59 in e378446

	internal static readonly DiagnosticDescriptor UnknownPlatform = DiagnosticDescriptorHelper.Create(RuleId,
	s_localizableTitle,
	CreateLocalizableResourceString(nameof(UseValidPlatformStringUnknownPlatform)),
	DiagnosticCategory.Interoperability,
	RuleLevel.BuildWarning,
	description: s_localizableDescription,
	isPortedFxCopRule: false,
	isDataflowRule: false);
	internal static readonly DiagnosticDescriptor InvalidVersion = DiagnosticDescriptorHelper.Create(RuleId,
	s_localizableTitle,
	CreateLocalizableResourceString(nameof(UseValidPlatformStringInvalidVersion)),
	DiagnosticCategory.Interoperability,
	RuleLevel.BuildWarning,
	description: s_localizableDescription,
	isPortedFxCopRule: false,
	isDataflowRule: false);
	internal static readonly DiagnosticDescriptor NoVersion = DiagnosticDescriptorHelper.Create(RuleId,
	s_localizableTitle,
	CreateLocalizableResourceString(nameof(UseValidPlatformStringNoVersion)),
	DiagnosticCategory.Interoperability,
	RuleLevel.BuildWarning,
	description: s_localizableDescription,
	isPortedFxCopRule: false,
	isDataflowRule: false);

Though this one can't easily be caught as context.ReportDiagnostic isn't invoked, but rather captured as a method group and passed down few calls to report a diagnostic.

Thanks, I'll create a separate PR to fix this issue.