[Performance] Improve SpecifyIFormatProvider (CA1305) performance #6865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
commented
Aug 19, 2023
| { | ||
| var semanticModel = argument.SemanticModel!; | ||
|
|
||
| var symbol = semanticModel.GetSymbolInfo(argument.Value.Syntax, oaContext.CancellationToken).Symbol; |
There was a problem hiding this comment.
@mavasani I assume semantic model calls are more expensive than getting info directly from IOperation?
Youssef1313
commented
Aug 19, 2023
Comment on lines
189
to
+193
| (targetMethod.Equals(stringFormatMemberWithStringAndObjectParameter) || | ||
| targetMethod.Equals(stringFormatMemberWithStringObjectAndObjectParameter) || | ||
| targetMethod.Equals(stringFormatMemberWithStringObjectObjectAndObjectParameter) || | ||
| targetMethod.Equals(stringFormatMemberWithStringAndParamsObjectParameter))) | ||
| targetMethod.Equals(stringFormatMemberWithStringAndParamsObjectParameter)) && | ||
| !oaContext.Options.IsConfiguredToSkipAnalysis(IFormatProviderAlternateStringRule, targetMethod, oaContext.ContainingSymbol, oaContext.Compilation)) |
There was a problem hiding this comment.
Symbol equality should be faster than IsConfiguredToSkipAnalysis
Youssef1313
commented
Aug 19, 2023
Comment on lines
-327
to
-333
| private static IEnumerable<int> GetIndexesOfParameterType(IMethodSymbol targetMethod, INamedTypeSymbol formatProviderType) | ||
| { | ||
| return targetMethod.Parameters | ||
| .Select((Parameter, Index) => (Parameter, Index)) | ||
| .Where(x => x.Parameter.Type.Equals(formatProviderType)) | ||
| .Select(x => x.Index); | ||
| } |
There was a problem hiding this comment.
I'm now looping over arguments directly and than checking if the parameter is of interest. The new implementation should hopefully be more performant and more straightforward.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6865 +/- ##
=======================================
Coverage 96.39% 96.39%
=======================================
Files 1403 1403
Lines 330977 330968 -9
Branches 10890 10891 +1
=======================================
- Hits 319055 319050 -5
+ Misses 9188 9182 -6
- Partials 2734 2736 +2 |
mavasani
approved these changes
Aug 28, 2023
|
@buyaa-n for another review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.