Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CA1826 to read option only when needed and use SpecialType checks #6872

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

Youssef1313
Copy link
Member

No description provided.

@Youssef1313 Youssef1313 requested a review from a team as a code owner August 20, 2023 09:06
@codecov
Copy link

codecov bot commented Aug 20, 2023

Codecov Report

Merging #6872 (f609a5e) into main (3587540) will increase coverage by 0.00%.
The diff coverage is 92.85%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6872   +/-   ##
=======================================
  Coverage   96.39%   96.39%           
=======================================
  Files        1403     1403           
  Lines      330977   330974    -3     
  Branches    10890    10890           
=======================================
  Hits       319055   319055           
+ Misses       9188     9185    -3     
  Partials     2734     2734           

Copy link
Contributor

@mavasani mavasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Youssef1313

@mavasani mavasani merged commit 4cbd36f into dotnet:main Aug 28, 2023
@Youssef1313 Youssef1313 deleted the CA1826-refactor branch August 28, 2023 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants