Brand main to 9.0 #6883
Merged
Brand main to 9.0 #6883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlossanlop
requested review from
jeffhandley,
sharwell,
ViktorHofer,
mmitche,
ericstj,
mavasani,
marcpopMSFT and
buyaa-n
carlossanlop
commented
Aug 21, 2023
Comment on lines
5
to
7
| <PreReleaseVersionLabel>beta1</PreReleaseVersionLabel> | ||
| <NetAnalyzersVersionPrefix>8.0.0</NetAnalyzersVersionPrefix> | ||
| <NetAnalyzersVersionPrefix>9.0.0</NetAnalyzersVersionPrefix> | ||
| <NetAnalyzersPreReleaseVersionLabel>preview</NetAnalyzersPreReleaseVersionLabel> |
There was a problem hiding this comment.
There are two pre-release version labels @mmitche. One is "preview" as you suggested in the email, the other one is beta1, but I assume you'd like me to also set that to preview, correct?
There was a problem hiding this comment.
I wouldn't change the one that is set to beta1. I believe it's used for analyzers that aren't linked to the SDK releases.
|
Looks like need to run |
|
I'm not sure why they use two different sets of pre-release labels. IMO it doesn't make a lot of sense to me. @sharwell any insight here? |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6883 +/- ##
==========================================
- Coverage 96.40% 96.39% -0.01%
==========================================
Files 1403 1403
Lines 330977 330977
Branches 10890 10890
==========================================
- Hits 319067 319058 -9
- Misses 9180 9185 +5
- Partials 2730 2734 +4 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.