Change localization branch to release/8.0.1xx temporarily #6890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlossanlop
requested review from
sharwell,
ViktorHofer,
ericstj,
mavasani,
cristianosuzuki77 and
buyaa-n
|
/backport to release/8.0.1xx |
|
I doubt the backport GH action is enabled in this repo. |
ViktorHofer
approved these changes
Aug 24, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6890 +/- ##
=======================================
Coverage 96.39% 96.39%
=======================================
Files 1403 1403
Lines 330977 330977
Branches 10890 10890
=======================================
+ Hits 319056 319061 +5
+ Misses 9187 9182 -5
Partials 2734 2734 |
sharwell
approved these changes
Aug 24, 2023
This was referenced Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the change we did in dotnet/runtime (dotnet/runtime#90812), we need to temporarily switch the OneLocBuild MirrorBranch to point to the release/8.0.1xx branch to ensure all localization changes go there until we ship. This change will be reverted after we ship, so that we point to main again. We need to backport this to the release/8.0.1xx branch as well (like in dotnet/runtime#90813).
@mavasani @sharwell @cristianosuzuki77 @buyaa-n @ericstj @ViktorHofer