Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SearchValues fixer introducing slight changes for edge case inputs #6926

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

MihaZupan
Copy link
Member

Fixed an edge-case code fixer issue where we would replace

new[] { (byte)'ÿ', (byte)'a', (byte)'e', (byte)'i', (byte)'o', (byte)'u' }

with

"ÿaeiou"u8

which is different ("ÿ"u8 being two bytes).

I'm not sure this is a meaningful case anyone would actually hit, but we should still avoid changing the behavior in an unobvious way.

@MihaZupan MihaZupan requested a review from a team as a code owner September 11, 2023 13:36
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #6926 (6df56d8) into main (8011355) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #6926      +/-   ##
==========================================
- Coverage   96.40%   96.39%   -0.01%     
==========================================
  Files        1402     1402              
  Lines      331964   332004      +40     
  Branches    11036    11039       +3     
==========================================
+ Hits       320016   320047      +31     
- Misses       9185     9193       +8     
- Partials     2763     2764       +1     

@buyaa-n buyaa-n merged commit 9dba21f into dotnet:main Sep 19, 2023
14 checks passed
@buyaa-n
Copy link
Contributor

buyaa-n commented Sep 19, 2023

I'm not sure this is a meaningful case anyone would actually hit, but we should still avoid changing the behavior in an unobvious way.

Sounds like we don't want to port it into 8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants