Add dotnet9 and dotnet9-transport feeds #6939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlossanlop
requested review from
jeffhandley,
sharwell,
ViktorHofer,
mmitche,
ericstj,
mavasani,
marcpopMSFT,
hoyosjs,
buyaa-n and
arunchndr
This comment was marked as outdated.
This comment was marked as outdated.
mavasani
approved these changes
Sep 14, 2023
|
I would attempt to remove the old feeds. |
ViktorHofer
approved these changes
Sep 14, 2023
carlossanlop
commented
Sep 14, 2023
carlossanlop
commented
Sep 14, 2023
carlossanlop
commented
Sep 14, 2023
carlossanlop
commented
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am unsure how roslyn-analyzers works but it seems to be correctly pushing the nuget packages generated from main into the
dotnet9feed. Example: TheMicrosoft.CodeAnalysis.NetAnalyzerspackage was correctly pushed to thedotnet9feed (see here) immediately after we merged this PR: #6935But just in case, and because it seems to be the proper change, I am adding the two missing feeds to
main.The old feeds are still there. I am unsure if we should remove them.