Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in CA1846 description #6968

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Conversation

mpidash
Copy link
Contributor

@mpidash mpidash commented Sep 30, 2023

No description provided.

@mpidash mpidash requested a review from a team as a code owner September 30, 2023 14:36
@mavasani
Copy link
Contributor

mavasani commented Oct 3, 2023

@mpidash Can you please run msbuild /t:pack at the repo root and push the changes to your branch?

@mpidash
Copy link
Contributor Author

mpidash commented Oct 3, 2023

Pushed the changes made by msbuild /t:pack.

I left them out of the initial PR because I was not sure if it was desirable to change the state of all languages to needs-review-translation when just fixing a typo in the English resources.

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #6968 (f4d8497) into main (84fb81c) will decrease coverage by 0.01%.
Report is 4 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #6968      +/-   ##
==========================================
- Coverage   96.43%   96.43%   -0.01%     
==========================================
  Files        1408     1410       +2     
  Lines      335751   335881     +130     
  Branches    11081    11090       +9     
==========================================
+ Hits       323772   323894     +122     
- Misses       9193     9195       +2     
- Partials     2786     2792       +6     

@mavasani mavasani merged commit 74409cd into dotnet:main Oct 4, 2023
11 checks passed
@mpidash mpidash deleted the ca1846-fix-typo branch March 22, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants