Generate unique name for CA1861 #7013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #7013 +/- ##
=======================================
Coverage 96.42% 96.43%
=======================================
Files 1412 1412
Lines 336397 336432 +35
Branches 11114 11117 +3
=======================================
+ Hits 324382 324425 +43
+ Misses 9212 9205 -7
+ Partials 2803 2802 -1 |
mavasani
reviewed
Oct 31, 2023
| if (containingMethod?.BlockBody is not null) | ||
| { | ||
| identifiers.AddRange(containingMethod.BlockBody.Locals.Select(l => l.Name)); | ||
| } |
There was a problem hiding this comment.
This feels like a good intermediate fix for the issue being fixed, though I do wish we had access to https://github.com/dotnet/roslyn/blob/main/src/Workspaces/SharedUtilitiesAndExtensions/Workspace/Core/Utilities/NameGenerator.cs, which is not a public API.
There was a problem hiding this comment.
What's stopping us from making it public or copying it?
mavasani
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation only considers the type's members when generating a name for the array. This PR extends the fixer to also consider method parameters and method locals.
Fixes #6981